fix(Client): generateInvite() scope validation (#9492)

almeidx · web-flow · commit b327f4925ff5 · 2023-05-01T22:11:11.000Z
diff --git a/packages/discord.js/src/client/Client.js b/packages/discord.js/src/client/Client.js
@@ -420,7 +420,7 @@ class Client extends BaseClient {
     if (!scopes.some(scope => [OAuth2Scopes.Bot, OAuth2Scopes.ApplicationsCommands].includes(scope))) {
       throw new DiscordjsTypeError(ErrorCodes.InvalidMissingScopes);
     }
-    if (scopes.some(scope => ![OAuth2Scopes.Bot].includes(scope)) && options.permissions) {
+    if (!scopes.includes(OAuth2Scopes.Bot) && options.permissions) {
       throw new DiscordjsTypeError(ErrorCodes.InvalidScopesWithPermissions);
     }
     const validScopes = Object.values(OAuth2Scopes);

Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ class Client extends BaseClient {`
`420`	`420`	`if (!scopes.some(scope => [OAuth2Scopes.Bot, OAuth2Scopes.ApplicationsCommands].includes(scope))) {`
`421`	`421`	`throw new DiscordjsTypeError(ErrorCodes.InvalidMissingScopes);`
`422`	`422`	`}`
`423`		`- if (scopes.some(scope => ![OAuth2Scopes.Bot].includes(scope)) && options.permissions) {`
	`423`	`+ if (!scopes.includes(OAuth2Scopes.Bot) && options.permissions) {`
`424`	`424`	`throw new DiscordjsTypeError(ErrorCodes.InvalidScopesWithPermissions);`
`425`	`425`	`}`
`426`	`426`	`const validScopes = Object.values(OAuth2Scopes);`