DEV: Update linting config and run gjs-codemod (#376)

Author: CvX

.discourse-compatibility

@@ -1,3 +1,4 @@
+< 3.5.0.beta5-dev: 71141cb6b274c778ad00c8f5eb17b3b6bc59dce9
 < 3.5.0.beta1-dev: 2ba204a1de2638a7959e588b88f3b6c7fcf7a70f
 < 3.4.0.beta2-dev: bdff229ca088ead9512ba333eea4fdbbb258b250
 < 3.4.0.beta1-dev: 2d0dc39767f0c68d333f113c550731a5546c3137

Gemfile.lock

@@ -14,42 +14,44 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.0)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
-    drb (2.2.1)
+    connection_pool (2.5.3)
+    drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.6)
+    logger (1.7.0)
     minitest (5.25.5)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
+    prism (1.4.0)
     racc (1.8.1)
-    rack (3.1.12)
+    rack (3.1.15)
     rainbow (3.1.1)
     regexp_parser (2.10.0)
-    rubocop (1.74.0)
+    rubocop (1.75.8)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -65,13 +67,13 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.30.3)
+    rubocop-rails (2.32.0)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.6.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -97,4 +99,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.6.6
+   2.6.9

assets/javascripts/discourse/components/code-view.gjs

@@ -0,0 +1,5 @@
+const CodeView = <template>
+  <pre><code class={{@codeClass}}>{{@value}}</code></pre>
+</template>;
+
+export default CodeView;

assets/javascripts/discourse/components/code-view.hbs

@@ -1,5 +1,7 @@
 import Component from "@glimmer/component";
+import { on } from "@ember/modifier";
 import { action } from "@ember/object";
+import didInsert from "@ember/render-modifiers/modifiers/did-insert";
 import { bind } from "discourse/lib/decorators";
 import loadScript from "discourse/lib/load-script";
 import themeColor from "../lib/themeColor";
@@ -89,4 +91,11 @@ export default class DataExplorerBarChart extends Component {
     this.chart.data = this.data;
     this.chart.update();
   }
+
+  <template>
+    <canvas
+      {{didInsert this.initChart}}
+      {{on "change" this.updateChartData}}
+    ></canvas>
+  </template>
 }

assets/javascripts/discourse/components/data-explorer-bar-chart.js renamed to assets/javascripts/discourse/components/data-explorer-bar-chart.gjs

@@ -1,8 +1,12 @@
 import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
+import { on } from "@ember/modifier";
 import { action } from "@ember/object";
 import { isBlank, isEmpty } from "@ember/utils";
+import ConditionalLoadingSpinner from "discourse/components/conditional-loading-spinner";
+import DButton from "discourse/components/d-button";
 import { debounce } from "discourse/lib/decorators";
+import OneTable from "./explorer-schema/one-table";
 
 export default class ExplorerSchema extends Component {
   @tracked filter;
@@ -135,4 +139,38 @@ export default class ExplorerSchema extends Component {
     this.hideSchema = false;
     this.args.updateHideSchema(false);
   }
+
+  <template>
+    {{#if this.hideSchema}}
+      <DButton
+        @action={{this.expandSchema}}
+        @icon="chevron-left"
+        class="no-text unhide"
+      />
+    {{else}}
+      <div class="schema">
+        <div class="schema-search inline-form full-width">
+          <input
+            type="text"
+            {{on "input" (action "filterChanged" value="target.value")}}
+          />
+          <DButton
+            @action={{this.collapseSchema}}
+            @icon="chevron-right"
+            class="no-text"
+          />
+        </div>
+
+        <div class="schema-container">
+          <ConditionalLoadingSpinner @condition={{this.loading}}>
+            <ul>
+              {{#each this.filteredTables as |table|}}
+                <OneTable @table={{table}} />
+              {{/each}}
+            </ul>
+          </ConditionalLoadingSpinner>
+        </div>
+      </div>
+    {{/if}}
+  </template>
 }

assets/javascripts/discourse/components/data-explorer-bar-chart.hbs

@@ -7,4 +7,14 @@ export default class EnumInfo extends Component {
       name,
     }));
   }
+
+  <template>
+    <ol>
+      {{#each this.enuminfo as |enum|}}
+        <li value={{enum.value}}>
+          {{enum.name}}
+        </li>
+      {{/each}}
+    </ol>
+  </template>
 }

assets/javascripts/discourse/components/explorer-schema.js renamed to assets/javascripts/discourse/components/explorer-schema.gjs

@@ -0,0 +1,78 @@
+import Component from "@glimmer/component";
+import { tracked } from "@glimmer/tracking";
+import { on } from "@ember/modifier";
+import icon from "discourse/helpers/d-icon";
+import { bind } from "discourse/lib/decorators";
+import { i18n } from "discourse-i18n";
+import EnumInfo from "./enum-info";
+
+export default class OneTable extends Component {
+  @tracked open = this.args.table.open;
+
+  get styles() {
+    return this.open ? "open" : "";
+  }
+
+  @bind
+  toggleOpen() {
+    this.open = !this.open;
+  }
+
+  <template>
+    <li class="schema-table {{this.styles}}">
+      {{! template-lint-enable no-invalid-interactive }}
+      <div
+        class="schema-table-name"
+        role="button"
+        {{on "click" this.toggleOpen}}
+      >
+        {{#if this.open}}
+          {{icon "caret-down"}}
+        {{else}}
+          {{icon "caret-right"}}
+        {{/if}}
+        {{@table.name}}
+      </div>
+
+      <div class="schema-table-cols">
+        {{#if this.open}}
+          <dl>
+            {{#each @table.columns as |col|}}
+              <div>
+                <dt
+                  class={{if col.sensitive "sensitive"}}
+                  title={{if col.sensitive (i18n "explorer.schema.sensitive")}}
+                >
+                  {{#if col.sensitive}}
+                    {{icon "triangle-exclamation"}}
+                  {{/if}}
+                  {{col.column_name}}
+                </dt>
+                <dd>
+                  {{col.data_type}}
+                  {{#if col.havetypeinfo}}
+                    <br />
+                    {{#if col.havepopup}}
+                      <div class="popup-info">
+                        {{icon "info"}}
+                        <div class="popup">
+                          {{col.column_desc}}
+                          {{#if col.enum}}
+                            <EnumInfo @col={{col}} />
+                          {{/if}}
+                        </div>
+                      </div>
+                    {{/if}}
+                    <span class="schema-typenotes">
+                      {{col.notes}}
+                    </span>
+                  {{/if}}
+                </dd>
+              </div>
+            {{/each}}
+          </dl>
+        {{/if}}
+      </div>
+    </li>
+  </template>
+}