DEV: Update linting config and run gjs-codemod (#25)

* DEV: Update linting config and run gjs-codemod

* on removal as well

* DEV: Update linting config and run gjs-codemod

Author: CvX

.discourse-compatibility

@@ -1,3 +1,4 @@
+< 3.5.0.beta5-dev: 29f680c6d45717a4eb53d1944322b08d8dc53638
 < 3.5.0.beta1-dev: 491e0aa9007213004d22a9e5a61f93ce8409f6de
 < 3.4.0.beta1-dev: e1c51ef38a9b53a9ee86bc4cdbe61561cc327eea
 < 3.3.0.beta1-dev: 43ba66cf0c7cc43aa36f9e6c49c5523cbc0a0190

Gemfile.lock

@@ -14,42 +14,44 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.1)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
-    drb (2.2.1)
+    connection_pool (2.5.3)
+    drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.6)
+    logger (1.7.0)
     minitest (5.25.5)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
+    prism (1.4.0)
     racc (1.8.1)
-    rack (3.1.12)
+    rack (3.1.15)
     rainbow (3.1.1)
     regexp_parser (2.10.0)
-    rubocop (1.74.0)
+    rubocop (1.76.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.45.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.39.0)
-      parser (>= 3.3.1.0)
+    rubocop-ast (1.45.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -65,13 +67,13 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.30.3)
+    rubocop-rails (2.32.0)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.6.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -98,4 +100,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.6.6
+   2.6.9

common/common.scss

@@ -9,7 +9,7 @@
   margin: 0 auto;
   font-size: var(--font-down-1);
 
-  @media screen and (max-width: 990px) {
+  @media screen and (width <= 990px) {
     text-align: center;
   }
 }

javascripts/discourse/connectors/below-footer/minimal-footer.gjs

@@ -0,0 +1,78 @@
+import Component from "@ember/component";
+import { classNames } from "@ember-decorators/component";
+import { modifier as modifierFn } from "ember-modifier";
+import { or } from "truth-helpers";
+import htmlSafe from "discourse/helpers/html-safe";
+
+const YEAR = new Date().getFullYear();
+
+function recalculateHight() {
+  const headerHeight = document.querySelector(".d-header-wrap").offsetHeight;
+  const footerHeight = document.querySelector(
+    ".below-footer-outlet"
+  ).offsetHeight;
+  const mainOutletStyles = getComputedStyle(
+    document.querySelector("#main-outlet")
+  );
+  const mainOutletPaddingTop = parseInt(
+    mainOutletStyles.getPropertyValue("padding-top"),
+    10
+  );
+  if (headerHeight && footerHeight && mainOutletPaddingTop) {
+    const mainOffset = headerHeight + footerHeight + mainOutletPaddingTop + 1;
+    document.querySelector("#main-outlet").style.minHeight =
+      "calc(100vh - " + mainOffset + "px)";
+  }
+}
+
+const adjustMinHeight = modifierFn(() => {
+  recalculateHight();
+  return () => recalculateHight();
+});
+
+@classNames("below-footer-outlet", "minimal-footer")
+export default class MinimalFooter extends Component {
+  <template>
+    {{#if this.showFooter}}
+      <footer {{adjustMinHeight}} class="discourse-minimal-footer">
+        <div class="discourse-minimal-footer-content">
+          {{#if settings.footer_logo}}
+            <div class="discourse-minimal-footer-logo">
+              <a
+                href={{settings.footer_logo_url}}
+                target="_blank"
+                rel="noopener noreferrer"
+              >
+                <img src={{settings.footer_logo}} />
+              </a>
+            </div>
+          {{/if}}
+
+          {{#if settings.footer_html_a}}
+            <p class="discourse-minimal-footer-row-a">
+              {{htmlSafe settings.footer_html_a}}
+            </p>
+          {{/if}}
+
+          {{#if settings.footer_html_b}}
+            <p class="discourse-minimal-footer-row-b">
+              {{htmlSafe settings.footer_html_b}}
+            </p>
+          {{/if}}
+
+          {{#if (or settings.show_copyright settings.footer_html_c)}}
+            <p class="discourse-minimal-footer-row-c">
+              {{#if settings.show_copyright}}
+                &copy;
+                {{YEAR}}
+              {{/if}}
+              {{#if settings.footer_html_c}}
+                {{htmlSafe settings.footer_html_c}}
+              {{/if}}
+            </p>
+          {{/if}}
+        </div>
+      </footer>
+    {{/if}}
+  </template>
+}

javascripts/discourse/connectors/below-footer/minimal-footer.hbs

@@ -1,11 +1,11 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.11.1",
-    "ember-template-lint": "7.0.1",
-    "eslint": "9.22.0",
+    "@discourse/lint-configs": "2.25.0",
+    "ember-template-lint": "7.8.1",
+    "eslint": "9.28.0",
     "prettier": "3.5.3",
-    "stylelint": "16.16.0"
+    "stylelint": "16.20.0"
   },
   "engines": {
     "node": ">= 22",