Skip to content

Commit 1a7b7d7

Browse files
authored
Only build MSIs that aren't also built in BuildPass2 during BuildPass1 (#60268)
1 parent 77a1f22 commit 1a7b7d7

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

eng/Build.props

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -254,13 +254,12 @@
254254
<InstallerProject Include="$(RepoRoot)src\Installers\Windows\WindowsHostingBundle\WindowsHostingBundle.wixproj" AdditionalProperties="Platform=x86" />
255255
</ItemGroup>
256256

257-
<!-- In a vertical build, only build the MSIs for the current vertical in the first pass and build the hosting bundle in the second pass -->
257+
<!--
258+
In a vertical build, only build the MSIs for the current vertical that aren't used in the hosting bundle in the first pass
259+
and build the hosting bundle and its dependencies in the second pass.
260+
-->
258261
<ItemGroup Condition="'$(DotNetBuild)' == 'true' and ('$(DotNetBuildPass)' == '' or '$(DotNetBuildPass)' == '1') and '$(_BuildWindowsInstallers)' == 'true'">
259-
<!-- Build the ANCM custom action -->
260-
<InstallerProject Include="$(RepoRoot)src\Installers\Windows\AspNetCoreModule-Setup\CustomAction\aspnetcoreCA.vcxproj" AdditionalProperties="Platform=$(_VcxTargetPlatform)" />
261-
<!-- Build the ANCM msis -->
262262
<InstallerProject Include="$(RepoRoot)src\Installers\Windows\AspNetCoreModule-Setup\ANCMIISExpressV2\AncmIISExpressV2.wixproj" AdditionalProperties="Platform=$(TargetArchitecture)" />
263-
<InstallerProject Include="$(RepoRoot)src\Installers\Windows\AspNetCoreModule-Setup\ANCMV2\ANCMV2.wixproj" AdditionalProperties="Platform=$(TargetArchitecture)" />
264263
</ItemGroup>
265264

266265
<ItemGroup>

0 commit comments

Comments
 (0)