UnixCertificateManager: implement IsTrusted. (#55335)

tmds · amcasey · web-flow · commit 399a5ed96f6d · 2024-05-31T00:49:13.000Z
* UnixCertificateManager: implement IsTrusted.

Consider the certificate trusted when .NET trusts it.

* Add explanatory comment

---------

Co-authored-by: Andrew Casey &lt;amcasey@users.noreply.github.com&gt;
diff --git a/src/Shared/CertificateGeneration/UnixCertificateManager.cs b/src/Shared/CertificateGeneration/UnixCertificateManager.cs
@@ -18,7 +18,14 @@ internal UnixCertificateManager(string subject, int version)
     {
     }
 
-    public override bool IsTrusted(X509Certificate2 certificate) => false;
+    public override bool IsTrusted(X509Certificate2 certificate)
+    {
+        using X509Chain chain = new X509Chain();
+        // This is just a heuristic for whether or not we should prompt the user to re-run with `--trust`
+        // so we don't need to check revocation (which doesn't really make sense for dev certs anyway)
+        chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck;
+        return chain.Build(certificate);
+    }
 
     protected override X509Certificate2 SaveCertificateCore(X509Certificate2 certificate, StoreName storeName, StoreLocation storeLocation)
     {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,14 @@ internal UnixCertificateManager(string subject, int version)`
`18`	`18`	`{`
`19`	`19`	`}`
`20`	`20`
`21`		`- public override bool IsTrusted(X509Certificate2 certificate) => false;`
	`21`	`+ public override bool IsTrusted(X509Certificate2 certificate)`
	`22`	`+ {`
	`23`	`+ using X509Chain chain = new X509Chain();`
	`24`	+ // This is just a heuristic for whether or not we should prompt the user to re-run with `--trust`
	`25`	`+ // so we don't need to check revocation (which doesn't really make sense for dev certs anyway)`
	`26`	`+ chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck;`
	`27`	`+ return chain.Build(certificate);`
	`28`	`+ }`
`22`	`29`
`23`	`30`	`protected override X509Certificate2 SaveCertificateCore(X509Certificate2 certificate, StoreName storeName, StoreLocation storeLocation)`
`24`	`31`	`{`