Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 35e4886

Browse files
authored
Make build input urls secret so they can be used with secure feeds. (#29225)
1 parent 2533ae7 commit 35e4886

5 files changed

+46
-19
lines changed

buildpipeline/DotNet-CoreFx-Trusted-Linux-Crossbuild.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,8 @@
371371
"value": "arm"
372372
},
373373
"PB_AssetRootUrl": {
374-
"value": ""
374+
"value": "",
375+
"isSecret": true
375376
},
376377
"PB_BuildArguments": {
377378
"value": "-BuildArch=$(PB_Architecture)"
@@ -423,7 +424,12 @@
423424
"value": "$(Build.BuildNumber)"
424425
},
425426
"PB_PackageVersionPropsUrl": {
426-
"value": ""
427+
"value": "",
428+
"isSecret": true
429+
},
430+
"PB_RestoreSource": {
431+
"value": "",
432+
"isSecret": true
427433
},
428434
"PB_SyncArguments": {
429435
"value": "-p -- /p:ArchGroup=$(PB_Architecture)",

buildpipeline/DotNet-CoreFx-Trusted-Linux.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,12 @@
370370
"allowOverride": true
371371
},
372372
"PB_AssetRootUrl": {
373-
"value": ""
373+
"value": "",
374+
"isSecret": true
375+
},
376+
"PB_RestoreSource": {
377+
"value": "",
378+
"isSecret": true
374379
},
375380
"PB_BuildArguments": {
376381
"value": "-buildArch=x64 -Release -stripSymbols",
@@ -427,7 +432,8 @@
427432
"allowOverride": true
428433
},
429434
"PB_PackageVersionPropsUrl": {
430-
"value": ""
435+
"value": "",
436+
"isSecret": true
431437
},
432438
"PB_SkipTests": {
433439
"value": "false",

buildpipeline/DotNet-CoreFx-Trusted-OSX.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@
7979
}
8080
},
8181
{
82-
"environment": {},
82+
"environment": {
83+
"PACKAGEVERSIONPROPSURL": "$(PB_PackageVersionPropsUrl)"
84+
},
8385
"enabled": true,
8486
"continueOnError": false,
8587
"alwaysRun": false,
@@ -351,13 +353,16 @@
351353
"allowOverride": true
352354
},
353355
"PB_PackageVersionPropsUrl": {
354-
"value": ""
356+
"value": "",
357+
"isSecret": true
355358
},
356-
"PACKAGEVERSIONPROPSURL": {
357-
"value": "$(PB_PackageVersionPropsUrl)"
359+
"PB_RestoreSource": {
360+
"value": "",
361+
"isSecret": true
358362
},
359363
"PB_AssetRootUrl": {
360-
"value": ""
364+
"value": "",
365+
"isSecret": true
361366
}
362367
},
363368
"demands": [

buildpipeline/DotNet-CoreFx-Trusted-Windows-NoTest.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@
129129
}
130130
},
131131
{
132-
"environment": {},
132+
"environment": {
133+
"PACKAGEVERSIONPROPSURL": "$(PB_PackageVersionPropsUrl)"
134+
},
133135
"enabled": true,
134136
"continueOnError": false,
135137
"alwaysRun": false,
@@ -446,13 +448,16 @@
446448
"allowOverride": true
447449
},
448450
"PB_PackageVersionPropsUrl": {
449-
"value": ""
451+
"value": "",
452+
"isSecret": true
450453
},
451-
"PACKAGEVERSIONPROPSURL": {
452-
"value": "$(PB_PackageVersionPropsUrl)"
454+
"PB_RestoreSource": {
455+
"value": "",
456+
"isSecret": true
453457
},
454458
"PB_AssetRootUrl": {
455-
"value": ""
459+
"value": "",
460+
"isSecret": true
456461
},
457462
"PB_UseEsrpSigning": {
458463
"value": "false",

buildpipeline/DotNet-CoreFx-Trusted-Windows.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@
129129
}
130130
},
131131
{
132-
"environment": {},
132+
"environment": {
133+
"PACKAGEVERSIONPROPSURL": "$(PB_PackageVersionPropsUrl)"
134+
},
133135
"enabled": true,
134136
"continueOnError": false,
135137
"alwaysRun": false,
@@ -523,13 +525,16 @@
523525
"allowOverride": true
524526
},
525527
"PB_PackageVersionPropsUrl": {
526-
"value": ""
528+
"value": "",
529+
"isSecret": true
527530
},
528-
"PACKAGEVERSIONPROPSURL": {
529-
"value": "$(PB_PackageVersionPropsUrl)"
531+
"PB_RestoreSource": {
532+
"value": "",
533+
"isSecret": true
530534
},
531535
"PB_AssetRootUrl": {
532-
"value": ""
536+
"value": "",
537+
"isSecret": true
533538
},
534539
"PB_UseEsrpSigning": {
535540
"value": "false",

0 commit comments

Comments
 (0)