Fix: Value cannot be null parameter name key (#34730)

Fixes #33831

Author: salihozkara

src/EFCore.Relational/Update/ModificationCommand.cs

@@ -673,7 +673,13 @@ void HandleJson(List<IColumnModification> columnModifications)
             var processedEntries = new List<IUpdateEntry>();
             foreach (var entry in _entries.Where(e => e.EntityType.IsMappedToJson()))
             {
-                var jsonColumn = GetTableMapping(entry.EntityType)!.Table.FindColumn(entry.EntityType.GetContainerColumnName()!)!;
+                var jsonColumn = GetTableMapping(entry.EntityType)!.Table.FindColumn(entry.EntityType.GetContainerColumnName()!);
+
+                if (jsonColumn == null)
+                {
+                    continue;
+                }
+
                 var jsonPartialUpdateInfo = FindJsonPartialUpdateInfo(entry, processedEntries);
 
                 if (jsonPartialUpdateInfo == null)

test/EFCore.Relational.Specification.Tests/Update/JsonUpdateFixtureBase.cs

@@ -201,6 +201,17 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con
                 b.Property(x => x.Name);
             });
 
+        modelBuilder.Entity<JsonEntityHasComplexChild>().Property(x => x.Id).ValueGeneratedNever();
+        modelBuilder.Entity<JsonEntityHasComplexChild>().OwnsOne(x => x.EntityReference, b =>
+        {
+            b.Property(x => x.Id).ValueGeneratedNever();
+            b.ToJson();
+            b.OwnsOne(x => x.AEntityReference, bb =>
+            {
+                bb.ToJson();
+            });
+        });
+
         base.OnModelCreating(modelBuilder, context);
     }
 

test/EFCore.Relational.Specification.Tests/Update/JsonUpdateTestBase.cs

@@ -77,6 +77,46 @@ public virtual Task Add_entity_with_json()
                 Assert.Equal("ss2", collectionLeaf[1].SomethingSomething);
             });
 
+    [ConditionalFact]
+    public virtual Task Add_owned_entity_with_json()
+        => TestHelpers.ExecuteWithStrategyInTransactionAsync(
+            CreateContext,
+            UseTransaction,
+            async context =>
+            {
+                var newEntity = new JsonEntityHasComplexChild
+                {
+                    Id = 1,
+                    Name = "NewEntity",
+                    EntityReference = new JsonEntityHasComplexChildForReference
+                    {
+                        Id = 2,
+                        Name = "NewReference",
+                        AEntityReference = new AJsonEntityHasComplexChildForReferenceForReference
+                        {
+                            Id = 3,
+                            Name = "NewReferenceReference"
+                        }
+                    }
+                };
+
+                context.Set<JsonEntityHasComplexChild>().Add(newEntity);
+                ClearLog();
+                await context.SaveChangesAsync();
+            },
+            async context =>
+            {
+                var query = await context.JsonEntitiesHasComplexChild.ToListAsync();
+                Assert.Equal(1, query.Count);
+
+                var newEntity = query.Where(e => e.Id == 1).Single();
+                Assert.Equal("NewEntity", newEntity.Name);
+                Assert.Equal(2, newEntity.EntityReference.Id);
+                Assert.Equal("NewReference", newEntity.EntityReference.Name);
+                Assert.Equal(3, newEntity.EntityReference.AEntityReference.Id);
+                Assert.Equal("NewReferenceReference", newEntity.EntityReference.AEntityReference.Name);
+            });
+
     [ConditionalFact]
     public virtual Task Add_entity_with_json_null_navigations()
         => TestHelpers.ExecuteWithStrategyInTransactionAsync(

test/EFCore.Specification.Tests/TestModels/JsonQuery/AJsonEntityHasComplexChildForReferenceForReference.cs

@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.TestModels.JsonQuery;
+
+#nullable disable
+
+public class AJsonEntityHasComplexChildForReferenceForReference
+{
+    public int Id { get; set; }
+    public string Name { get; set; }
+
+    public int? ParentId { get; set; }
+    public JsonEntityHasComplexChildForReference Parent { get; set; }
+}

test/EFCore.Specification.Tests/TestModels/JsonQuery/JsonEntityHasComplexChild.cs

@@ -0,0 +1,14 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.TestModels.JsonQuery;
+
+#nullable disable
+
+public class JsonEntityHasComplexChild
+{
+    public int Id { get; set; }
+    public string Name { get; set; }
+
+    public JsonEntityHasComplexChildForReference EntityReference { get; set; }
+}

test/EFCore.Specification.Tests/TestModels/JsonQuery/JsonEntityHasComplexChildForReference.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.EntityFrameworkCore.TestModels.JsonQuery;
+
+#nullable disable
+
+public class JsonEntityHasComplexChildForReference
+{
+    public int Id { get; set; }
+    public string Name { get; set; }
+
+    // A is required for sorting
+    public AJsonEntityHasComplexChildForReferenceForReference AEntityReference { get; set; }
+
+    public int? ParentId { get; set; }
+    public JsonEntityHasComplexChild Parent { get; set; }
+}

test/EFCore.Specification.Tests/TestModels/JsonQuery/JsonQueryContext.cs

@@ -16,6 +16,7 @@ public class JsonQueryContext(DbContextOptions options) : DbContext(options)
     public DbSet<JsonEntityInheritanceBase> JsonEntitiesInheritance { get; set; }
     public DbSet<JsonEntityAllTypes> JsonEntitiesAllTypes { get; set; }
     public DbSet<JsonEntityConverters> JsonEntitiesConverters { get; set; }
+    public DbSet<JsonEntityHasComplexChild> JsonEntitiesHasComplexChild { get; set; }
 
     public static Task SeedAsync(JsonQueryContext context)
     {