Skip to content

Work on inlined primitive collections (VALUES) #36159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roji
Copy link
Member

@roji roji commented May 29, 2025

  • Refactor and generalize the pruning of the VALUES _ord column, moving it from RelationalTypeMappingPostprocessor to SqlPruner.
  • Ensure that inlined parameterized collections (EF.Constant) preserved ordering via _ord and specifies the type mapping.

Fixes #36158

@roji roji requested a review from cincuranet May 29, 2025 12:05
* Refactor and generalize the pruning of the VALUES _ord column,
  moving it from RelationalTypeMappingPostprocessor to SqlPruner.
* Ensure that inlined parameterized collections (EF.Constant)
  preserved ordering via _ord and specifies the type mapping.

Fixes dotnet#36158
@roji roji marked this pull request as ready for review May 30, 2025 15:51
@roji roji requested a review from a team as a code owner May 30, 2025 15:51
@roji roji enabled auto-merge (squash) May 31, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlined VALUES parameterized collection does not preserve ordering or type mapping
1 participant