Merge pull request #342 from wting/fix_consumer_falsiness

Remove Consumer falsiness.

Author: Dana Powers

kafka/consumer/base.py

@@ -50,7 +50,7 @@ def __init__(self, client, group, topic, partitions=None, auto_commit=True,
         self.client.load_metadata_for_topics(topic)
         self.offsets = {}
 
-        if not partitions:
+        if partitions is None:
             partitions = self.client.get_partition_ids_for_topic(topic)
         else:
             assert all(isinstance(x, numbers.Integral) for x in partitions)
@@ -86,7 +86,7 @@ def fetch_last_known_offsets(self, partitions=None):
         if self.group is None:
             raise ValueError('KafkaClient.group must not be None')
 
-        if not partitions:
+        if partitions is None:
             partitions = self.client.get_partition_ids_for_topic(self.topic)
 
         responses = self.client.send_offset_fetch_request(
@@ -133,7 +133,7 @@ def commit(self, partitions=None):
                 return
 
             reqs = []
-            if not partitions:  # commit all partitions
+            if partitions is None:  # commit all partitions
                 partitions = self.offsets.keys()
 
             for partition in partitions:
@@ -194,7 +194,7 @@ def pending(self, partitions=None):
         Keyword Arguments:
             partitions (list): list of partitions to check for, default is to check all
         """
-        if not partitions:
+        if partitions is None:
             partitions = self.offsets.keys()
 
         total = 0