Skip to content

Commit ed4cab6

Browse files
authored
Return connection state explicitly after close in connect() (#1778)
1 parent 6ca6f36 commit ed4cab6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

kafka/conn.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ def connect(self):
354354
next_lookup = self._next_afi_sockaddr()
355355
if not next_lookup:
356356
self.close(Errors.KafkaConnectionError('DNS failure'))
357-
return
357+
return self.state
358358
else:
359359
log.debug('%s: creating new socket', self)
360360
self._sock_afi, self._sock_addr = next_lookup
@@ -409,6 +409,7 @@ def connect(self):
409409
' Disconnecting.', self, ret)
410410
errstr = errno.errorcode.get(ret, 'UNKNOWN')
411411
self.close(Errors.KafkaConnectionError('{} {}'.format(ret, errstr)))
412+
return self.state
412413

413414
# Needs retry
414415
else:
@@ -443,6 +444,7 @@ def connect(self):
443444
if time.time() > request_timeout + self.last_attempt:
444445
log.error('Connection attempt to %s timed out', self)
445446
self.close(Errors.KafkaConnectionError('timeout'))
447+
return self.state
446448

447449
return self.state
448450

0 commit comments

Comments
 (0)