-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drush make has problems with wget 1.12 and the HTTPS certificate of drupal.org. #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you submit a PR which conditionally adds the flag we will consider it. I also want an explanation about why disabling this feature is a secure approach. Some alternatives that I can think of:
|
No reply. I will reopen this if one appears per my prior comment. |
wget 1.11.4 fails with the following links:
This version of wget is provided also with drush package for Windows, at: http://drush.ws/drush_windows_installer It is related to: Example fail:
|
Here's a one line solution: echo "check_certificate = off" >> ~/.wgetrc |
Problem
When drush make uses patches from drupal.org on a server running 1.12 it returns an because of the https certificate that drupal.org uses. This can happen with other sources too. Ubuntu 10.04 uses 1.12 as its latest package for wget. This problem is fixed with wget 1.13. In Ubuntu 12.04 they use wget 1.13 so there its no problem.
Fix
When you add the flag --no-check-certificate to wget on 1.12 it continues but does not check the certificate.
Proposed solution
It would be great to be able to add --no-check-certificate as a parameter to the wget call when the version is 1.12.
This call to check if wget is available is here. The version could be checked there too. If the version is 1.12 the flag could be added to the exec call. That line would look something like this
References
The text was updated successfully, but these errors were encountered: