lint

Author: tobio

internal/fleet/agent_policy_resource_test.go

@@ -2,6 +2,7 @@ package fleet_test
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"testing"
 
@@ -139,7 +140,7 @@ func checkResourceAgentPolicyDestroy(s *terraform.State) error {
 		}
 		packagePolicy, diag := fleet.ReadAgentPolicy(context.Background(), fleetClient, rs.Primary.ID)
 		if diag.HasError() {
-			return fmt.Errorf(diag[0].Summary)
+			return errors.New(diag[0].Summary)
 		}
 		if packagePolicy != nil {
 			return fmt.Errorf("agent policy id=%v still exists, but it should have been removed", rs.Primary.ID)
@@ -165,14 +166,14 @@ func checkResourceAgentPolicySkipDestroy(s *terraform.State) error {
 		}
 		packagePolicy, diag := fleet.ReadAgentPolicy(context.Background(), fleetClient, rs.Primary.ID)
 		if diag.HasError() {
-			return fmt.Errorf(diag[0].Summary)
+			return errors.New(diag[0].Summary)
 		}
 		if packagePolicy == nil {
 			return fmt.Errorf("agent policy id=%v does not exist, but should still exist when skip_destroy is true", rs.Primary.ID)
 		}
 
 		if diag = fleet.DeleteAgentPolicy(context.Background(), fleetClient, rs.Primary.ID); diag.HasError() {
-			return fmt.Errorf(diag[0].Summary)
+			return errors.New(diag[0].Summary)
 		}
 	}
 	return nil

internal/fleet/fleet_server_host_resource_test.go

@@ -2,6 +2,7 @@ package fleet_test
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"testing"
 
@@ -103,7 +104,7 @@ func checkResourceFleetServerHostDestroy(s *terraform.State) error {
 		}
 		packagePolicy, diag := fleet.ReadFleetServerHost(context.Background(), fleetClient, rs.Primary.ID)
 		if diag.HasError() {
-			return fmt.Errorf(diag[0].Summary)
+			return errors.New(diag[0].Summary)
 		}
 		if packagePolicy != nil {
 			return fmt.Errorf("FleetServerHost id=%v still exists, but it should have been removed", rs.Primary.ID)

internal/fleet/integration_policy_resource_test.go

@@ -2,6 +2,7 @@ package fleet_test
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"testing"
 
@@ -72,15 +73,15 @@ func checkResourceIntegrationPolicyDestroy(s *terraform.State) error {
 		case "elasticstack_fleet_integration_policy":
 			integrationPolicy, diag := fleet.ReadPackagePolicy(context.Background(), fleetClient, rs.Primary.ID)
 			if diag.HasError() {
-				return fmt.Errorf(diag[0].Summary)
+				return errors.New(diag[0].Summary)
 			}
 			if integrationPolicy != nil {
 				return fmt.Errorf("integration policy id=%v still exists, but it should have been removed", rs.Primary.ID)
 			}
 		case "elasticstack_fleet_agent_policy":
 			agentPolicy, diag := fleet.ReadAgentPolicy(context.Background(), fleetClient, rs.Primary.ID)
 			if diag.HasError() {
-				return fmt.Errorf(diag[0].Summary)
+				return errors.New(diag[0].Summary)
 			}
 			if agentPolicy != nil {
 				return fmt.Errorf("agent policy id=%v still exists, but it should have been removed", rs.Primary.ID)
@@ -134,7 +135,7 @@ resource "elasticstack_fleet_integration_policy" "test_policy" {
 	    "enabled": true,
 	    "vars": {
 	  	  "listen_address": "localhost",
-  		  "listen_port": 8080, 
+  		  "listen_port": 8080,
 		  "data_stream.dataset": "tcp.generic",
 		  "tags": [],
 		  "syslog_options": "field: message\n#format: auto\n#timezone: Local\n",
@@ -189,7 +190,7 @@ resource "elasticstack_fleet_integration_policy" "test_policy" {
 	    "enabled": true,
 	    "vars": {
 	  	  "listen_address": "localhost",
-  		  "listen_port": 8085, 
+  		  "listen_port": 8085,
 		  "data_stream.dataset": "tcp.generic",
 		  "tags": [],
 		  "syslog_options": "field: message\n#format: auto\n#timezone: Local\n",

internal/fleet/output_resource_test.go

@@ -2,6 +2,7 @@ package fleet_test
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"testing"
 
@@ -226,7 +227,7 @@ func checkResourceOutputDestroy(s *terraform.State) error {
 		}
 		packagePolicy, diag := fleet.ReadOutput(context.Background(), fleetClient, rs.Primary.ID)
 		if diag.HasError() {
-			return fmt.Errorf(diag[0].Summary)
+			return errors.New(diag[0].Summary)
 		}
 		if packagePolicy != nil {
 			return fmt.Errorf("output id=%v still exists, but it should have been removed", rs.Primary.ID)