Skip to content

Commit 8f92af1

Browse files
authored
Persist override value during data view read (#550)
* Persist override value during data view read * Changelog
1 parent c439022 commit 8f92af1

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
### Fixed
77
- Handle nil LastExecutionDate's in Kibana alerting rules. ([#508](https://github.com/elastic/terraform-provider-elasticstack/pull/508))
88
- Import all relevant attributes during `elasticstack_fleet_output` import ([#522](https://github.com/elastic/terraform-provider-elasticstack/pull/522))
9+
- Fix issue when setting `override` in `elasticstack_kibana_data_view` resource ([#550](https://github.com/elastic/terraform-provider-elasticstack/pull/550))
910

1011
## [0.11.0] - 2023-12-12
1112

internal/kibana/data_view/acc_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ func TestAccResourceDataView(t *testing.T) {
3333
Config: testAccResourceDataViewBasicDV(indexName),
3434
Check: resource.ComposeTestCheckFunc(
3535
resource.TestCheckResourceAttrSet("elasticstack_kibana_data_view.dv", "id"),
36+
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "override", "true"),
3637
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "data_view.name", indexName),
3738
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "data_view.source_filters.#", "2"),
3839
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "data_view.field_formats.event_time.id", "date_nanos"),
@@ -45,6 +46,7 @@ func TestAccResourceDataView(t *testing.T) {
4546
Config: testAccResourceDataViewBasicDVUpdated(indexName),
4647
Check: resource.ComposeTestCheckFunc(
4748
resource.TestCheckResourceAttrSet("elasticstack_kibana_data_view.dv", "id"),
49+
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "override", "false"),
4850
resource.TestCheckResourceAttr("elasticstack_kibana_data_view.dv", "data_view.name", indexName),
4951
resource.TestCheckNoResourceAttr("elasticstack_kibana_data_view.dv", "data_view.source_filters"),
5052
resource.TestCheckNoResourceAttr("elasticstack_kibana_data_view.dv", "data_view.field_formats"),
@@ -80,6 +82,7 @@ resource "elasticstack_elasticsearch_index" "my_index" {
8082
}
8183
8284
resource "elasticstack_kibana_data_view" "dv" {
85+
override = true
8386
data_view = {
8487
title = "%s*"
8588
name = "%s"
@@ -121,6 +124,7 @@ resource "elasticstack_elasticsearch_index" "my_index" {
121124
}
122125
123126
resource "elasticstack_kibana_data_view" "dv" {
127+
override = false
124128
data_view = {
125129
title = "%s*"
126130
name = "%s"

internal/kibana/data_view/schema.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ func (m tfModelV0) FromResponse(ctx context.Context, resp *data_views.DataViewRe
270270
ID: m.ID.ValueString(),
271271
SpaceID: m.SpaceID.ValueString(),
272272
DataView: dv,
273+
Override: m.Override.ValueBool(),
273274
}
274275
return model, nil
275276
}

0 commit comments

Comments
 (0)