Skip to content

Commit 6c679f7

Browse files
committed
src: return Maybe from a couple of functions
nodejs/node#39603
1 parent f133df7 commit 6c679f7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

shell/renderer/electron_renderer_client.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ void ElectronRendererClient::DidCreateScriptContext(
8585
node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
8686

8787
// Setup node environment for each window.
88-
bool initialized = node::InitializeContext(renderer_context);
89-
CHECK(initialized);
88+
v8::Maybe<bool> initialized = node::InitializeContext(renderer_context);
89+
CHECK(!initialized.IsNothing());
9090

9191
node::Environment* env =
9292
node_bindings_->CreateEnvironment(renderer_context, nullptr);

shell/renderer/web_worker_observer.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ void WebWorkerObserver::WorkerScriptReadyForEvaluation(
6363
node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
6464

6565
// Setup node environment for each window.
66-
bool initialized = node::InitializeContext(worker_context);
67-
CHECK(initialized);
66+
v8::Maybe<bool> initialized = node::InitializeContext(worker_context);
67+
CHECK(!initialized.IsNothing());
6868
node::Environment* env =
6969
node_bindings_->CreateEnvironment(worker_context, nullptr);
7070

0 commit comments

Comments
 (0)