Skip to content

Commit 9fe827b

Browse files
committed
Code comment fixes
1 parent 829a6c8 commit 9fe827b

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

typescript/packages/subsurface-viewer/src/layers/axes2d/line-fragment.glsl.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ export default `\
44
55
precision highp float;
66
7-
//uniform vec4 uColor;
8-
97
out vec4 fragColor;
108
119
void main(void) {

typescript/packages/subsurface-viewer/src/layers/axes2d/line-vertex.glsl.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ export default `\
44
55
precision highp float;
66
7-
// uniform float uClipZ;
8-
97
in vec3 positions;
108
119
void main(void) {

typescript/packages/subsurface-viewer/src/layers/colormap/colormapLayer.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { BitmapLayerPickingInfo, BitmapLayerProps } from "@deck.gl/layers";
22
import { BitmapLayer } from "@deck.gl/layers";
3-
import type { LayerProps, PickingInfo } from "@deck.gl/core";
3+
import type { LayerContext, LayerProps, PickingInfo } from "@deck.gl/core";
44

55
import type {
66
LayerPickInfo,
@@ -20,6 +20,7 @@ import type { ContinuousLegendDataType } from "../../components/ColorLegend";
2020
import type { ShaderModule } from "@luma.gl/shadertools";
2121
import type { Model } from "@luma.gl/engine";
2222
import { project32 } from "@deck.gl/core";
23+
import { UniformValue } from "@luma.gl/core";
2324

2425
function getImageData(
2526
colorMapName: string,
@@ -121,9 +122,11 @@ export default class ColormapLayer extends BitmapLayer<ColormapLayerProps> {
121122
super.initializeState();
122123
}
123124

124-
setShaderModuleProps(
125-
...props: Parameters<Model["shaderInputs"]["setProps"]>
126-
): void {
125+
draw(args: {
126+
moduleParameters?: unknown;
127+
uniforms: UniformValue;
128+
context: LayerContext;
129+
}): void {
127130
if (!this.isLoaded) {
128131
if (typeof this.props.reportBoundingBox !== "undefined") {
129132
const xMin = this.props.bounds[0] as number;
@@ -138,7 +141,12 @@ export default class ColormapLayer extends BitmapLayer<ColormapLayerProps> {
138141
});
139142
}
140143
}
144+
super.draw(args);
145+
}
141146

147+
setShaderModuleProps(
148+
...props: Parameters<Model["shaderInputs"]["setProps"]>
149+
): void {
142150
// Set property for modelMatrix.
143151
const m = getModelMatrix(
144152
this.props.rotDeg,

0 commit comments

Comments
 (0)