-
Notifications
You must be signed in to change notification settings - Fork 42
fix: Subsurface viewer - Assorted fixes to wells layer and multi pick hook #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Anders2303
merged 21 commits into
equinor:master
from
Anders2303:subsurface-viewer/multi-pick-fixes
Apr 2, 2025
Merged
fix: Subsurface viewer - Assorted fixes to wells layer and multi pick hook #2491
Anders2303
merged 21 commits into
equinor:master
from
Anders2303:subsurface-viewer/multi-pick-fixes
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty types. Cleaned up some dirty casts
hkfb
requested changes
Mar 28, 2025
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
nilscb
approved these changes
Mar 28, 2025
w1nklr
requested changes
Mar 28, 2025
...pt/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts
Show resolved
Hide resolved
...pt/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts
Show resolved
Hide resolved
...pt/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts
Show resolved
Hide resolved
hkfb
requested changes
Mar 28, 2025
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
hkfb
requested changes
Mar 28, 2025
typescript/packages/subsurface-viewer/src/layers/wells/wellsLayer.ts
Outdated
Show resolved
Hide resolved
hkfb
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring!
w1nklr
requested changes
Mar 28, 2025
...pt/packages/subsurface-viewer/src/hooks/useMultiViewPicking/MultiViewPickingInfoAssembler.ts
Outdated
Show resolved
Hide resolved
w1nklr
approved these changes
Mar 31, 2025
hkfb
pushed a commit
that referenced
this pull request
Apr 2, 2025
## [1.10.4](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.10.4) (2025-04-02) ### Bug Fixes * Subsurface viewer - Assorted fixes to wells layer and multi pick hook ([#2491](#2491)) ([b4673a1](b4673a1))
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMultiViewPicking
hook able to return picks from multiple wells if hovering on overlapping wellsWellFeatureCollection
.colorMappingFunction
prop to match thecreateColorMapFunction
from emerson table.