Skip to content

fix: Subsurface viewer - Assorted fixes to wells layer and multi pick hook #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Anders2303
Copy link
Collaborator

@Anders2303 Anders2303 commented Mar 27, 2025

  • Made the useMultiViewPicking hook able to return picks from multiple wells if hovering on overlapping wells
    • Generally makes it so the hook is able to pick multiple items from the same layer, whereas before it would only take the first
    • Added a new multi-pick example with wells to show it
  • Adds a more descriptive typing for the GeoJson feature we use in the WellsLayer data prop -- WellFeatureCollection.
    • Most notably, we now specify what should be in the properties object.
    • Made most utils take this new specified typing, and removed/clean up a buuunch of spots where we were just assuming validity and casting any-values
  • Exposed or specified some extra types that made sense to export as well
  • Updated the colorMappingFunction prop to match the createColorMapFunction from emerson table.
    • The only difference is that it now specifies a couple of extra (optional) params. We were actually using these params, so the typing should now reflect that
  • Refactored some messy code in the wells layer class

@Anders2303 Anders2303 requested a review from hkfb March 27, 2025 15:41
@hkfb hkfb requested review from nilscb and w1nklr March 28, 2025 07:09
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@Anders2303 Anders2303 requested a review from w1nklr March 28, 2025 14:00
@Anders2303 Anders2303 requested a review from w1nklr March 31, 2025 07:58
@Anders2303 Anders2303 merged commit b4673a1 into equinor:master Apr 2, 2025
8 checks passed
hkfb pushed a commit that referenced this pull request Apr 2, 2025
## [1.10.4](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.10.4) (2025-04-02)

### Bug Fixes

* Subsurface viewer - Assorted fixes to wells layer and multi pick hook ([#2491](#2491)) ([b4673a1](b4673a1))
@hkfb
Copy link
Collaborator

hkfb commented Apr 2, 2025

🎉 This issue has been resolved in version [email protected] 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants