Skip to content

Root from devcontainer dir #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 20, 2024
Merged

Root from devcontainer dir #1

merged 20 commits into from
Apr 20, 2024

Conversation

erichlf
Copy link
Owner

@erichlf erichlf commented Apr 20, 2024

The main portion of this PR changes from using a git command to find the root of the devcontainer to a pure lua function that searches for the devcontainer closest to the root directory, i.e. /. The toplevel flag determines if we use the closest or furthest up the direcotry tree result.

  • Use lua to find uppermost devctontainer
  • Add option to find toplevel or nearest
  • Separated the logic for running the devcontainer from the window creation.
  • Added the ability to cancel bringing up the devcontainer.
  • Updated devcontainer.json and Dockerfile to work more generally.
  • Removed some multiply defined behaviors
  • Add ability to close window with q or escape
  • Added on_detach function to handle setting prev_win, win, and buf to -1 after the window is closed
  • Use lua to run commands rather than calling a script

@erichlf erichlf merged commit 68c5df9 into main Apr 20, 2024
@erichlf erichlf deleted the root-from-devcontainer-dir branch April 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant