Skip to content

feat: Option to track JSX components as references #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 1, 2025
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Feb 12, 2025

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

  • Added a new jsx option to analyze().
  • Updated Referencer to track JSX references.
  • Added tests to verify the behavior.

Related Issues

fixes #645

Is there anything you'd like reviewers to focus on?

Please double-check that I'm covering enough scenarios in the tests. I'm not very familiar with JSX, so it's possible I missed some cases.

@nzakas
Copy link
Member Author

nzakas commented Feb 24, 2025

Updated and also added a few tests to ensure that JSX references are being tracked the same way regular references are.

@nzakas nzakas moved this from Needs Triage to Implementing in Triage Feb 26, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tests that I think would be good to add.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 6dd3cbc into main Mar 1, 2025
12 checks passed
@mdjermanovic mdjermanovic deleted the issue645 branch March 1, 2025 20:16
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Mar 1, 2025
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Support JSX references
2 participants