-
-
Notifications
You must be signed in to change notification settings - Fork 212
feat: Option to track JSX components as references #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated and also added a few tests to ensure that JSX references are being tracked the same way regular references are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tests that I think would be good to add.
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
jsx
option toanalyze()
.Referencer
to track JSX references.Related Issues
fixes #645
Is there anything you'd like reviewers to focus on?
Please double-check that I'm covering enough scenarios in the tests. I'm not very familiar with JSX, so it's possible I missed some cases.