Skip to content

ESP_LVGL_PORT lvgl_port_flush_rgb_vsync_ready_callback in IRAM (BSP-639) #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
mattmatt206 opened this issue Feb 25, 2025 · 1 comment
Open
1 task done

Comments

@mattmatt206
Copy link

Related area

ESP_LVGL_PORT

Hardware specification

ESP32S3

Is your feature request related to a problem?

when LCD_RGB_ISR_IRAM_SAFE is enabled in SDK config, the following error is given:
lcd_panel.rgb: esp_lcd_rgb_panel_register_event_callbacks(397): on_frame_buf_complete callback not in IRAM
ESP_ERROR_CHECK failed: esp_err_t 0x102 (ESP_ERR_INVALID_ARG) at 0x420405fc

Describe the solution you'd like

add IRAM attribute to vsync ready callback so can be used with LCD_RGB_ISR_IRAM_SAFE enabled

proposed change
line 68 (esp_lvgl_port_disp.c)
static bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);
to
static IRAM_ATTR bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx);

and
line 446 (esp_lvgl_port_disp.c)
static bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx)
to
static IRAM_ATTR bool lvgl_port_flush_rgb_vsync_ready_callback(esp_lcd_panel_handle_t panel_io, const esp_lcd_rgb_panel_event_data_t *edata, void *user_ctx)

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@github-actions github-actions bot changed the title ESP_LVGL_PORT lvgl_port_flush_rgb_vsync_ready_callback in IRAM ESP_LVGL_PORT lvgl_port_flush_rgb_vsync_ready_callback in IRAM (BSP-639) Feb 25, 2025
@owen63
Copy link

owen63 commented May 12, 2025

Any update on this? I've hit the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants