Skip to content

[Antithesis] Allow undetermined result from valdidation #19971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serathius opened this issue May 17, 2025 · 1 comment
Open

[Antithesis] Allow undetermined result from valdidation #19971

serathius opened this issue May 17, 2025 · 1 comment

Comments

@serathius
Copy link
Member

What would you like to be added?

Currently result of validation other the linearization is represented as an error and passed to antithesis as Always assertion that this error is nil. However, in some cases some validations are not run at all, for example no watch validation will be run if we were not able to read the persisted requests.

From antithesis point of view this validation succeeded, so the uploaded artifacts for watch validation might include case that didn't do any watch requests. It would be better to introduce 3 state logic of: success, failure, unknown. Call assert always only for success/failure and don't call it in case unknown. This would be similar to what we already do for linearization, however there unknown means timeout which we also want to keep track off.

Why is this needed?

Have more accurate reports in antithesis that point to real successes/failures instead of pointing to unknown cases.

/cc @henrybear327 @joshjms @nwnt @marcus-hodgson-antithesis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants