Skip to content

Commit 7a438a6

Browse files
committed
Minor simplifications
1 parent 2a122d1 commit 7a438a6

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

v5/merge.go

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,16 @@ func MergePatch(docData, patchData []byte) ([]byte, error) {
120120
}
121121

122122
func doMergePatch(docData, patchData []byte, mergeMerge bool) ([]byte, error) {
123-
doc := &partialDoc{}
123+
if !json.Valid(docData) {
124+
return nil, errBadJSONDoc
125+
}
124126

125-
if !json.Valid(docData) || !json.Valid(patchData) {
126-
return nil, ErrInvalid
127+
if !json.Valid(patchData) {
128+
return nil, errBadJSONPatch
127129
}
128130

131+
doc := &partialDoc{}
132+
129133
docErr := doc.UnmarshalJSON(docData)
130134

131135
patch := &partialDoc{}
@@ -137,22 +141,15 @@ func doMergePatch(docData, patchData []byte, mergeMerge bool) ([]byte, error) {
137141
}
138142

139143
if isSyntaxError(patchErr) {
140-
if json.Valid(patchData) {
141-
return patchData, nil
142-
}
143-
144-
return nil, errBadJSONPatch
144+
return patchData, nil
145145
}
146146

147147
if docErr == nil && doc.obj == nil {
148148
return nil, errBadJSONDoc
149149
}
150150

151151
if patchErr == nil && patch.obj == nil {
152-
if json.Valid(patchData) {
153-
return patchData, nil
154-
}
155-
return nil, errBadJSONPatch
152+
return patchData, nil
156153
}
157154

158155
if docErr != nil || patchErr != nil {

0 commit comments

Comments
 (0)