Bugfix in reduction feature aggr.

davnov134 · facebook-github-bot · commit 73ba66e4abb1 · 2022-10-07T01:45:24.000-07:00
Summary: Bugfix

Reviewed By: bottler

Differential Revision: D40146840

fbshipit-source-id: a8415c361ed3cd939999b87311aff4d3bb1bcfe1
diff --git a/pytorch3d/implicitron/models/view_pooler/feature_aggregator.py b/pytorch3d/implicitron/models/view_pooler/feature_aggregator.py
@@ -229,7 +229,7 @@ def forward(
             masks_sampled.device,
             self.exclude_target_view,
         )
-        aggr_weigths = masks_sampled * sampling_mask
+        aggr_weigths = masks_sampled[..., 0] * sampling_mask[..., None]
         feats_aggregated = {
             k: _avgmaxstd_reduction_function(
                 f,

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ def forward(`
`229`	`229`	`masks_sampled.device,`
`230`	`230`	`self.exclude_target_view,`
`231`	`231`	`)`
`232`		`- aggr_weigths = masks_sampled * sampling_mask`
	`232`	`+ aggr_weigths = masks_sampled[..., 0] * sampling_mask[..., None]`
`233`	`233`	`feats_aggregated = {`
`234`	`234`	`k: _avgmaxstd_reduction_function(`
`235`	`235`	`f,`