black_formatting setting is ignored
#1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for the contribution! 😄 This can be simplified a little since 1 is "truthy" and 0 is "falsy". We also don't need to provide the default here anymore, they're now defined in if (not cfg.black_formatting and not force) or cell.cell_type != 'code': return |
seeM
changed the title
black_formatting setting is ignored
|
Thanks for the suggestion! Applied in 19a95dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
black_formattingoption is now callingstr2boolfrom fastcore so it's value when retrieved bycfg.get('black_formatting')is either 0 or 1, so the code path that does the black formatting is currently inaccessible. This changes the comparison to check against1.