Skip to content

User-friendly error if py file has # %% comments with unexpected format #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

User-friendly error if py file has # %% comments with unexpected format #1211

merged 1 commit into from
Nov 8, 2022

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Nov 8, 2022

fixes #1188

@seeM seeM requested review from jph00 and hamelsmu November 8, 2022 12:57
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@seeM seeM mentioned this pull request Nov 8, 2022
Closed
@seeM seeM merged commit c384aa5 into AnswerDotAI:master Nov 8, 2022
@seeM seeM deleted the fix-1188 branch November 8, 2022 13:08
@deven-gqc deven-gqc mentioned this pull request Nov 8, 2022
Closed
@jph00
Copy link
Contributor

jph00 commented Nov 8, 2022

Lgtm, except perhaps use a different exception. The one you picked is mainly for abstract classes

@jph00 jph00 added the enhancement New feature or request label Nov 8, 2022
@seeM seeM mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jph00 jph00 Awaiting requested review from jph00

@hamelsmu hamelsmu Awaiting requested review from hamelsmu

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error with nbdev_export
2 participants
@seeM @jph00