Fix encoding issue for Windows OS User especially for non-English user #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a windows os user in South Korea.
When I try to develop a small niche package using nbdev I faced an encoding problem.
As you may know, the default encoding for Korean in Windows OS is cp949. Therefore, when nbdev using Path.read_text from pathlib, their default encoding is cp949 and it causes a decoding error.
The simplest solution that I can figure out is explicitly set encoding for Path.read_text as 'utf-8'.
I believe it will not cause any change for most of users, at the same time it prevent not only Korean but also Japanese or other language users on Windows OS from encoding issues.
I hope this can help more Korean users enhance their productivity by nbdev.