Allow clean to keep some metadata keys #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jph00
requested changes
Jul 27, 2022
Certain tooling puts useful information in the metadata and cell metadata sections. nbdev_clean currently wipes out everything except some hardcoded keys. Allow the user to specify additional keys via settings.ini
Thanks for the review! Appreciate your patience while I'm internalizing the coding style. As for the tests, I debated using |
|
Yes this is great! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain tooling puts useful information in the metadata and cell metadata
sections. nbdev_clean currently wipes out everything except some hardcoded
keys.
Allow the user to specify additional keys via settings.ini
Fixes: #600
cc: @jph00