add parts type and enable coverage checking (#491)

* add parts type

* enable coverage check

* test if flaky

* Revert "test if flaky"

This reverts commit 76388dd.

* ignore line

* add why we're ignoring else

Author: gurgunday

.taprc

@@ -1,3 +1,2 @@
-check-coverage: false
 files:
   - test/**/*.test.js

index.js

@@ -94,6 +94,8 @@ function fastifyMultipart (fastify, options, done) {
             const key = reqBodyKeys[i]
             const field = req.body[key]
 
+            /* Don't modify the body if a field doesn't have a value or an attached buffer */
+            /* istanbul ignore else */
             if (field.value !== undefined) {
               body[key] = field.value
             } else if (field._buf) {
@@ -453,7 +455,8 @@ function fastifyMultipart (fastify, options, done) {
       try {
         await unlink(filepath)
       } catch (error) {
-        this.log.error(error, 'could not delete file')
+        /* istanbul ignore next */
+        this.log.error(error, 'Could not delete file')
       }
     }
   }
@@ -462,6 +465,8 @@ function fastifyMultipart (fastify, options, done) {
     const parts = this[kMultipartHandler](options)
     let part
     while ((part = await parts()) != null) {
+      /* Only return a part if the file property exists */
+      /* istanbul ignore else */
       if (part.file) {
         return part
       }

types/index.d.ts

@@ -158,6 +158,12 @@ declare namespace fastifyMultipart {
        * Max number of header key=>value pairs
        */
       headerPairs?: number;
+
+      /**
+       * For multipart forms, the max number of parts (fields + files)
+       * @default 1000
+       */
+      parts?: number;
     };
   }
 

types/index.test-d.ts

@@ -14,6 +14,9 @@ const runServer = async () => {
 
   app.register(fastifyMultipart, {
     attachFieldsToBody: true,
+    limits: {
+      parts: 500
+    },
     onFile: (part: MultipartFile) => {
       console.log(part)
     }
@@ -73,7 +76,7 @@ const runServer = async () => {
 
   // busboy
   app.post('/', async function (req, reply) {
-    const options: Partial<BusboyConfig> = { limits: { fileSize: 1000 } }
+    const options: Partial<BusboyConfig> = { limits: { fileSize: 1000, parts: 500 } }
     const data = await req.file(options)
     if (!data) throw new Error('missing file')
     await pump(data.file, fs.createWriteStream(data.filename))