Add transfer-encoding for streaming (#338)

Author: mcollina

eslint.config.js

@@ -3,7 +3,7 @@
 module.exports = require('neostandard')({
   ignores: [
     ...require('neostandard').resolveIgnoresFromGitignore(),
-    'test/benchmark.js',
+    'test/benchmark.js'
   ],
   ts: true
 })

lib/request.js

@@ -107,6 +107,7 @@ function Request (options) {
 
   this.headers = {}
   this.rawHeaders = []
+
   const headers = options.headers || {}
 
   for (const field in headers) {
@@ -159,6 +160,7 @@ function Request (options) {
     payloadResume = true
     // we override the content-type
     this.headers['content-type'] = stream.contentType
+    this.headers['transfer-encoding'] = 'chunked'
   }
 
   if (payload && typeof payload !== 'string' && !payloadResume && !Buffer.isBuffer(payload)) {
@@ -206,7 +208,7 @@ function Request (options) {
         this.push(null)
       })
     } else {
-      // Stream v1 are handled in index.js asynchronously
+      // Stream v1 are handled in index.js synchronously
       this._read = readEverythingElse
     }
   }
@@ -239,7 +241,6 @@ function readEverythingElse () {
       if (this._lightMyRequest.simulate.end !== false) {
         this.push(null)
       }
-
       return
     }
 

package.json

@@ -21,6 +21,7 @@
     "form-auto-content": "^3.2.1",
     "form-data": "^4.0.0",
     "formdata-node": "^6.0.3",
+    "multer": "^1.4.5-lts.1",
     "neostandard": "^0.12.0",
     "tinybench": "^3.0.0",
     "tsd": "^0.31.0",

test/index.test.js

@@ -8,6 +8,7 @@ const zlib = require('node:zlib')
 const http = require('node:http')
 const eos = require('end-of-stream')
 const express = require('express')
+const multer = require('multer')
 
 const inject = require('../index')
 const parseURL = require('../lib/parse-url')
@@ -2275,3 +2276,41 @@ test('query method works', (t, done) => {
     done()
   })
 })
+
+test('should return the file content', async (t) => {
+  const multerMiddleware = multer({
+    storage: multer.memoryStorage(),
+    limits: {
+      fileSize: 1024
+    }
+  })
+
+  const app = express()
+
+  app.use((req, res, next) => {
+    if (req.headers['content-type'].indexOf('multipart/form-data') === 0) {
+      req.multipart = true
+    }
+    next()
+  })
+
+  app.post('/hello', multerMiddleware.single('textFile'), (req, res) => {
+    res.send(req.file.buffer.toString('utf8'))
+  })
+  app.use((err, req, res, next) => {
+    console.warn(err)
+    res.status(500).send('Something was wrong')
+  })
+
+  const formData = new FormData()
+  formData.append('textFile', new Blob(['some data']), 'sample.txt')
+
+  const response = await inject(app, {
+    method: 'POST',
+    url: 'http://example.com:8080/hello',
+    payload: formData
+  })
+
+  t.assert.equal(response.statusCode, 200)
+  t.assert.equal(response.payload, 'some data')
+})