Skip to content

Commit 472a5a3

Browse files
committed
some pytest fixes
1 parent 47db6e7 commit 472a5a3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

firebase_admin/_http_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def headers_and_body(
171171
method: str,
172172
url: str,
173173
**kwargs: typing.Any,
174-
) -> typing.Tuple[requests.structures.CaseInsensitiveDict[str], _AnyT]:
174+
) -> typing.Tuple['requests.structures.CaseInsensitiveDict[str]', _AnyT]:
175175
resp = self.request(method, url, **kwargs)
176176
return resp.headers, self.parse_body(resp)
177177

firebase_admin/ml.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -826,13 +826,13 @@ def _validate_model_id(model_id: str) -> None:
826826
raise ValueError('Model ID format is invalid.')
827827

828828

829-
def _validate_operation_name(op_name: str) -> str:
829+
def _validate_operation_name(op_name: typing.Any) -> str:
830830
if not _OPERATION_NAME_PATTERN.match(op_name):
831831
raise ValueError('Operation name format is invalid.')
832832
return op_name
833833

834834

835-
def _validate_display_name(display_name: str) -> str:
835+
def _validate_display_name(display_name: typing.Any) -> str:
836836
if not _DISPLAY_NAME_PATTERN.match(display_name):
837837
raise ValueError('Display name format is invalid.')
838838
return display_name
@@ -971,7 +971,7 @@ def handle_operation(
971971
raise _utils.handle_operation_error(error)
972972
raise exceptions.UnknownError(message='Internal Error: Malformed Operation.')
973973

974-
op_name = _validate_operation_name(typing.cast(str, operation['name']))
974+
op_name = _validate_operation_name(operation.get('name'))
975975
metadata = typing.cast(typing.Dict[str, typing.Any], operation.get('metadata', {}))
976976
metadata_type = metadata.get('@type', '')
977977
if not metadata_type.endswith('ModelOperationMetadata'):

0 commit comments

Comments
 (0)