Skip to content

Commit a44e39e

Browse files
committed
Updating tests
1 parent 97d0b84 commit a44e39e

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

firebase_admin/messaging.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,8 @@ def send_all(self, messages, dry_run=False):
379379
"""Sends the given messages to FCM via the batch API."""
380380
if not isinstance(messages, list):
381381
raise ValueError('Messages must be an list of messaging.Message instances.')
382+
if len(messages) > 100:
383+
raise ValueError('send_all messages must not contain more than 100 messages.')
382384

383385
responses = []
384386

tests/test_messaging.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,15 @@ def test_invalid_tokens_type(self, tokens):
5353
expected = 'MulticastMessage.tokens must be a list of strings.'
5454
assert str(excinfo.value) == expected
5555

56+
def test_tokens_over_one_hundred(self):
57+
with pytest.raises(ValueError) as excinfo:
58+
messaging.MulticastMessage(tokens=['token' for i in xrange(0, 101)])
59+
expected = 'MulticastMessage.tokens must not contain more than 100 tokens.'
60+
assert str(excinfo.value) == expected
61+
5662
def test_tokens_type(self):
5763
messaging.MulticastMessage(tokens=['token'])
64+
messaging.MulticastMessage(tokens=['token' for i in xrange(0, 100)])
5865

5966

6067
class TestMessageEncoder(object):
@@ -1385,6 +1392,13 @@ def test_invalid_send_all(self, msg):
13851392
expected = 'Messages must be an list of messaging.Message instances.'
13861393
assert str(excinfo.value) == expected
13871394

1395+
def test_invalid_over_one_hundred(self):
1396+
msg = messaging.Message(topic='foo')
1397+
with pytest.raises(ValueError) as excinfo:
1398+
messaging.send_all([msg for i in xrange(0, 101)])
1399+
expected = 'send_all messages must not contain more than 100 messages.'
1400+
assert str(excinfo.value) == expected
1401+
13881402
def test_send_all(self):
13891403
payload = json.dumps({'name': 'message-id'})
13901404
_ = self._instrument_batch_messaging_service(

0 commit comments

Comments
 (0)