Skip to content

Commit 25468da

Browse files
amotinFedorUporovVstack
authored andcommitted
ZTS: Remove TXG_TIMEOUT from dedup_quota test (openzfs#17150)
It seems `fio` in `ddt_dedup_vdev_limit` overwhelms the system with the amount of dirty data caused by DDT updates within one TXG due to tiny 1KB records used, while I see no reason for this test to extend the TXGs beyond default. Signed-off-by: Alexander Motin <[email protected]> Sponsored by: iXsystems, Inc. Reviewed-by: Allan Jude <[email protected]> Reviewed-by: @ImAwsumm Reviewed-by: Tony Hutter <[email protected]>
1 parent 7203036 commit 25468da

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

tests/zfs-tests/tests/functional/dedup/dedup_quota.ksh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ VDEV_GENERAL="$TEST_BASE_DIR/vdevfile.general.$$"
5050
VDEV_DEDUP="$TEST_BASE_DIR/vdevfile.dedup.$$"
5151
POOL="dedup_pool"
5252

53-
save_tunable TXG_TIMEOUT
54-
5553
# we set the dedup log txg interval to 1, to get a log flush every txg,
5654
# effectively disabling the log. without this it's hard to predict when and
5755
# where things appear on-disk
@@ -66,7 +64,6 @@ function cleanup
6664
destroy_pool $POOL
6765
fi
6866
log_must rm -fd $VDEV_GENERAL $VDEV_DEDUP $MOUNTDIR
69-
log_must restore_tunable TXG_TIMEOUT
7067
log_must restore_tunable DEDUP_LOG_TXG_MAX
7168
log_must restore_tunable DEDUP_LOG_FLUSH_ENTRIES_MIN
7269
}
@@ -84,7 +81,6 @@ function do_setup
8481
# Use 'xattr=sa' to prevent selinux xattrs influencing our accounting
8582
log_must zpool create -o ashift=12 -f -O xattr=sa -m $MOUNTDIR $POOL $VDEV_GENERAL
8683
log_must zfs set compression=off dedup=on $POOL
87-
log_must set_tunable32 TXG_TIMEOUT 600
8884
}
8985

9086
function dedup_table_size

0 commit comments

Comments
 (0)