convex-backend PR 108: print tablename in unique() error message (#38187)

Improves usefulness of the error thrown when `.unique()` returns more than 1 result by now also printing the table name.

Improves quality of life: currently, it can be cumbersome to identify the actual table in which these non-unique elements belong.

This solution is a bit work-around-y, but it's the only solution I could come up with. Let me know if there is a better way to achieve this!

----

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Co-authored-by: Jan-Georges Jersild Balin <[email protected]>
GitOrigin-RevId: 3b5e5bc6888326f8a6d615c3272cdf66aa285987

Author: 2 people

src/server/impl/query_impl.ts

@@ -166,9 +166,15 @@ export class QueryImpl implements Query<GenericTableInfo> {
     | { type: "executing"; queryId: number }
     | { type: "closed" }
     | { type: "consumed" };
+  private tableNameForErrorMessages: string;
 
   constructor(query: SerializedQuery) {
     this.state = { type: "preparing", query };
+    if (query.source.type === "FullTableScan") {
+      this.tableNameForErrorMessages = query.source.tableName;
+    } else {
+      this.tableNameForErrorMessages = query.source.indexName.split(".")[0];
+    }
   }
 
   private takeQuery(): SerializedQuery {
@@ -333,7 +339,7 @@ export class QueryImpl implements Query<GenericTableInfo> {
       return null;
     }
     if (first_two_array.length === 2) {
-      throw new Error(`unique() query returned more than one result: 
+      throw new Error(`unique() query returned more than one result from table ${this.tableNameForErrorMessages}:
  [${first_two_array[0]._id}, ${first_two_array[1]._id}, ...]`);
     }
     return first_two_array[0];