Skip to content

Commit f56cc3e

Browse files
eltigerchinoLms24
andauthored
fix(sveltekit): Add import attribute for node exports (#16528)
This patch changes the `node` export in the `package.json` file to include an `import` version (similar to the other exports) to fix sveltejs/kit#13869 . In SvelteKit, we're now bundling dependencies on the server that specify SvelteKit as a dependency or peerDependency. This has caused an issue where builds with `@sentry/sveltekit` were being bundled incorrectly. Adding the `import` attribute fixes this so that Vite resolves to the ESM build of Sentry. --------- Co-authored-by: Lukas Stracke <[email protected]>
1 parent 0635a5b commit f56cc3e

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@sentry-internal/test-utils": "link:../../../test-utils",
2424
"@sentry/core": "latest || *",
2525
"@sveltejs/adapter-auto": "^3.0.0",
26-
"@sveltejs/kit": "2.21.2",
26+
"@sveltejs/kit": "^2.21.3",
2727
"@sveltejs/vite-plugin-svelte": "^3.0.0",
2828
"svelte": "^5.0.0-next.115",
2929
"svelte-check": "^3.6.0",

dev-packages/e2e-tests/test-applications/sveltekit-2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@sentry/core": "latest || *",
2424
"@sveltejs/adapter-auto": "^3.0.0",
2525
"@sveltejs/adapter-node": "^2.0.0",
26-
"@sveltejs/kit": "2.21.2",
26+
"@sveltejs/kit": "^2.21.3",
2727
"@sveltejs/vite-plugin-svelte": "^3.0.0",
2828
"svelte": "^4.2.8",
2929
"svelte-check": "^3.6.0",

dev-packages/e2e-tests/test-applications/sveltekit-cloudflare-pages/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"devDependencies": {
2121
"@playwright/test": "^1.45.3",
2222
"@sveltejs/adapter-cloudflare": "^5.0.3",
23-
"@sveltejs/kit": "2.21.2",
23+
"@sveltejs/kit": "^2.21.3",
2424
"@sveltejs/vite-plugin-svelte": "^5.0.3",
2525
"svelte": "^5.20.2",
2626
"svelte-check": "^4.1.4",

packages/sveltekit/package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@
2828
"import": "./build/esm/index.client.js",
2929
"require": "./build/cjs/index.client.js"
3030
},
31-
"node": "./build/cjs/index.server.js"
31+
"node": {
32+
"import": "./build/esm/index.server.js",
33+
"require": "./build/cjs/index.server.js"
34+
}
3235
}
3336
},
3437
"publishConfig": {
@@ -83,5 +86,6 @@
8386
},
8487
"volta": {
8588
"extends": "../../package.json"
86-
}
89+
},
90+
"sideEffects": false
8791
}

0 commit comments

Comments
 (0)