Only expose keys on span data if is on

Author: sl0thentr0py

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Add new sidekiq config `report_only_dead_jobs` ([#2581](https://github.com/getsentry/sentry-ruby/pull/2581))
 - Add `max_nesting` of 10 to breadcrumbs data serialization ([#2583](https://github.com/getsentry/sentry-ruby/pull/2583))
+- Only expose `active_storage` keys on span data if `send_default_pii` is on ([#2589](https://github.com/getsentry/sentry-ruby/pull/2589))
 
 ### Bug Fixes
 

sentry-rails/lib/sentry/rails/tracing/active_storage_subscriber.rb

@@ -33,7 +33,10 @@ def self.subscribe!
               duration: duration
             ) do |span|
               payload.each do |key, value|
-                span.set_data(key, value) unless key == START_TIMESTAMP_NAME
+                next if key == START_TIMESTAMP_NAME
+                next if key == :key && !Sentry.configuration.send_default_pii
+
+                span.set_data(key, value)
               end
             end
           end

sentry-rails/spec/sentry/rails/tracing/active_storage_subscriber_spec.rb

@@ -48,9 +48,34 @@
       expect(span[:op]).to eq("file.service_upload.active_storage")
       expect(span[:origin]).to eq("auto.file.rails")
       expect(span[:description]).to eq("Disk")
-      expect(span.dig(:data, :key)).to eq(p.cover.key)
+      expect(span.dig(:data, :key)).to be_nil
       expect(span[:trace_id]).to eq(request_transaction.dig(:contexts, :trace, :trace_id))
     end
+
+    context "with send_default_pii = true" do
+      before do
+        make_basic_app do |config|
+          config.traces_sample_rate = 1.0
+          config.send_default_pii = true
+          config.rails.tracing_subscribers = [described_class]
+        end
+      end
+
+      it "records the :key in span.data" do
+        # make sure AnalyzeJob will be executed immediately
+        ActiveStorage::AnalyzeJob.queue_adapter.perform_enqueued_jobs = true
+
+        p = Post.create!
+        get "/posts/#{p.id}/attach"
+
+        request_transaction = transport.events.last.to_hash
+        expect(request_transaction[:type]).to eq("transaction")
+        expect(request_transaction[:spans].count).to eq(2)
+
+        span = request_transaction[:spans][1]
+        expect(span.dig(:data, :key)).to eq(p.cover.key)
+      end
+    end
   end
 
   context "when transaction is not sampled" do