Skip to content

Commit 6123979

Browse files
authored
server : allow to specify custom prompt for penalty calculation (#3727)
1 parent b9ec82d commit 6123979

File tree

4 files changed

+54
-3
lines changed

4 files changed

+54
-3
lines changed

common/sampling.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,12 +203,14 @@ static llama_token llama_sampling_sample_impl(
203203
}
204204

205205
// apply penalties
206-
if (!prev.empty()) {
206+
const auto& penalty_tokens = params.use_penalty_prompt_tokens ? params.penalty_prompt_tokens : prev;
207+
const int penalty_tokens_used_size = std::min((int)penalty_tokens.size(), penalty_last_n);
208+
if (penalty_tokens_used_size) {
207209
const float nl_logit = logits[llama_token_nl(llama_get_model(ctx_main))];
208210

209211
llama_sample_repetition_penalties(ctx_main, &cur_p,
210-
prev.data() + prev.size() - penalty_last_n,
211-
penalty_last_n, penalty_repeat, penalty_freq, penalty_present);
212+
penalty_tokens.data() + penalty_tokens.size() - penalty_tokens_used_size,
213+
penalty_tokens_used_size, penalty_repeat, penalty_freq, penalty_present);
212214

213215
if (!penalize_nl) {
214216
for (size_t idx = 0; idx < cur_p.size; idx++) {

common/sampling.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ typedef struct llama_sampling_params {
3636
float cfg_scale = 1.f; // how strong is guidance
3737

3838
std::unordered_map<llama_token, float> logit_bias; // logit bias for specific tokens
39+
40+
std::vector<llama_token> penalty_prompt_tokens;
41+
bool use_penalty_prompt_tokens = false;
3942
} llama_sampling_params;
4043

4144
// general sampler context

examples/server/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ node index.js
148148

149149
`frequency_penalty`: Repeat alpha frequency penalty (default: 0.0, 0.0 = disabled);
150150

151+
`penalty_prompt`: This will replace the `prompt` for the purpose of the penalty evaluation. Can be either `null`, a string or an array of numbers representing tokens (default: `null` = use the original `prompt`).
152+
151153
`mirostat`: Enable Mirostat sampling, controlling perplexity during text generation (default: 0, 0 = disabled, 1 = Mirostat, 2 = Mirostat 2.0).
152154

153155
`mirostat_tau`: Set the Mirostat target entropy, parameter tau (default: 5.0).

examples/server/server.cpp

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,42 @@ struct llama_server_context
761761
slot->prompt = "";
762762
}
763763

764+
slot->sparams.penalty_prompt_tokens.clear();
765+
slot->sparams.use_penalty_prompt_tokens = false;
766+
const auto &penalty_prompt = data.find("penalty_prompt");
767+
if (penalty_prompt != data.end())
768+
{
769+
if (penalty_prompt->is_string())
770+
{
771+
const auto penalty_prompt_string = penalty_prompt->get<std::string>();
772+
auto penalty_tokens = llama_tokenize(model, penalty_prompt_string, false);
773+
slot->sparams.penalty_prompt_tokens.swap(penalty_tokens);
774+
if (slot->params.n_predict > 0)
775+
{
776+
slot->sparams.penalty_prompt_tokens.reserve(slot->sparams.penalty_prompt_tokens.size() + slot->params.n_predict);
777+
}
778+
slot->sparams.use_penalty_prompt_tokens = true;
779+
}
780+
else if (penalty_prompt->is_array())
781+
{
782+
const auto n_tokens = penalty_prompt->size();
783+
slot->sparams.penalty_prompt_tokens.reserve(n_tokens + std::max(0, slot->params.n_predict));
784+
const int n_vocab = llama_n_vocab(model);
785+
for (const auto &penalty_token : *penalty_prompt)
786+
{
787+
if (penalty_token.is_number_integer())
788+
{
789+
const auto tok = penalty_token.get<llama_token>();
790+
if (tok >= 0 && tok < n_vocab)
791+
{
792+
slot->sparams.penalty_prompt_tokens.push_back(tok);
793+
}
794+
}
795+
}
796+
slot->sparams.use_penalty_prompt_tokens = true;
797+
}
798+
}
799+
764800
slot->sparams.logit_bias.clear();
765801

766802
if (json_value(data, "ignore_eos", false))
@@ -992,6 +1028,12 @@ struct llama_server_context
9921028
slot.generated_text += token_str;
9931029
slot.has_next_token = true;
9941030

1031+
if (slot.ctx_sampling->params.use_penalty_prompt_tokens && result.tok != -1)
1032+
{
1033+
// we can change penalty_prompt_tokens because it is always created from scratch each request
1034+
slot.ctx_sampling->params.penalty_prompt_tokens.push_back(result.tok);
1035+
}
1036+
9951037
// check if there is incomplete UTF-8 character at the end
9961038
bool incomplete = false;
9971039
for (unsigned i = 1; i < 5 && i <= slot.generated_text.size(); ++i)
@@ -1183,6 +1225,8 @@ struct llama_server_context
11831225
{"repeat_penalty", slot.sparams.penalty_repeat},
11841226
{"presence_penalty", slot.sparams.penalty_present},
11851227
{"frequency_penalty", slot.sparams.penalty_freq},
1228+
{"penalty_prompt_tokens", slot.sparams.penalty_prompt_tokens},
1229+
{"use_penalty_prompt_tokens", slot.sparams.use_penalty_prompt_tokens},
11861230
{"mirostat", slot.sparams.mirostat},
11871231
{"mirostat_tau", slot.sparams.mirostat_tau},
11881232
{"mirostat_eta", slot.sparams.mirostat_eta},

0 commit comments

Comments
 (0)