Skip to content

Invalid syntax highlighting with or condition || #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacek-jablonski opened this issue Jun 23, 2023 · 0 comments · May be fixed by #468
Open

Invalid syntax highlighting with or condition || #224

jacek-jablonski opened this issue Jun 23, 2023 · 0 comments · May be fixed by #468
Labels
bug Something isn't working

Comments

@jacek-jablonski
Copy link

Describe the bug
Syntax is invalid formatted with || at the begging of the line

To Reproduce
Steps to reproduce the behavior:
This workflow casuses invalid hightlighting on the last line:

name: "CI / CD"

on: workflow_call

jobs:
  prepare:
    name: "Prepare"
    runs-on: "ubuntu-22.04"
    outputs:
      perform-tests: "${{ steps.should-perform-tests.outputs.perform-tests }}"
      perform-lint: "${{ steps.should-perform-lint.outputs.perform-lint }}"

    steps:
      - name: "Should perform tests"
        id: "should-perform-tests"
        run: |
          echo "perform-tests=1" >> $GITHUB_OUTPUT

      - name: "Should perform lint"
        id: "should-perform-lint"
        run: |
          echo "perform-lint=1" >> $GITHUB_OUTPUT

  ci:
    name: "CI"
    runs-on: "ubuntu-22.04"
    needs: ["prepare"]
    if: >
      needs.prepare.outputs.perform-lint == 1
      || needs.prepare.outputs.perform-tests == 1

Expected behavior
The last line shouldn't be red and slanted.

Screenshots
image

Extension Version
v0.25.8

@jacek-jablonski jacek-jablonski added the bug Something isn't working label Jun 23, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup moved this from Backlog 🗒 to Triaged 📝 in GitHub Actions VS Code Extension Jul 13, 2023
@cdce8p cdce8p linked a pull request May 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triaged 📝
Development

Successfully merging a pull request may close this issue.

1 participant