Skip to content

Commit 478f36a

Browse files
authored
Add missing default value for some Bool cli flags (#26082)
In #25959 I forgot to add default values to some Bool flags (which were BoolT in cli/v1, BoolT means default to be true) This PR adds the default "Value" for them. ``` ./cmd/manager_logging.go: }, cli.BoolTFlag{ ./cmd/manager_logging.go- Name: "rotate, r", ./cmd/manager_logging.go- Usage: "Rotate logs", -- ./cmd/manager_logging.go: }, cli.BoolTFlag{ ./cmd/manager_logging.go- Name: "daily, d", ./cmd/manager_logging.go- Usage: "Rotate logs daily", -- ./cmd/manager_logging.go: }, cli.BoolTFlag{ ./cmd/manager_logging.go- Name: "compress, z", ./cmd/manager_logging.go- Usage: "Compress rotated logs", -- ./cmd/admin.go: cli.BoolTFlag{ ./cmd/admin.go- Name: "force-smtps", ./cmd/admin.go- Usage: "SMTPS is always used on port 465. Set this to force SMTPS on other ports.", -- ./cmd/admin.go: cli.BoolTFlag{ ./cmd/admin.go- Name: "skip-verify", ./cmd/admin.go- Usage: "Skip TLS verify.", -- ./cmd/admin.go: cli.BoolTFlag{ ./cmd/admin.go- Name: "disable-helo", ./cmd/admin.go- Usage: "Disable SMTP helo.", -- ./cmd/admin.go: cli.BoolTFlag{ ./cmd/admin.go- Name: "skip-local-2fa", ./cmd/admin.go- Usage: "Skip 2FA to log on.", -- ./cmd/admin.go: cli.BoolTFlag{ ./cmd/admin.go- Name: "active", ./cmd/admin.go- Usage: "This Authentication Source is Activated.", ```
1 parent f5c7d4c commit 478f36a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

cmd/admin.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,12 @@ var (
298298
&cli.BoolFlag{
299299
Name: "force-smtps",
300300
Usage: "SMTPS is always used on port 465. Set this to force SMTPS on other ports.",
301+
Value: true,
301302
},
302303
&cli.BoolFlag{
303304
Name: "skip-verify",
304305
Usage: "Skip TLS verify.",
306+
Value: true,
305307
},
306308
&cli.StringFlag{
307309
Name: "helo-hostname",
@@ -311,6 +313,7 @@ var (
311313
&cli.BoolFlag{
312314
Name: "disable-helo",
313315
Usage: "Disable SMTP helo.",
316+
Value: true,
314317
},
315318
&cli.StringFlag{
316319
Name: "allowed-domains",
@@ -320,10 +323,12 @@ var (
320323
&cli.BoolFlag{
321324
Name: "skip-local-2fa",
322325
Usage: "Skip 2FA to log on.",
326+
Value: true,
323327
},
324328
&cli.BoolFlag{
325329
Name: "active",
326330
Usage: "This Authentication Source is Activated.",
331+
Value: true,
327332
},
328333
}
329334

cmd/manager_logging.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ var (
117117
Name: "rotate",
118118
Aliases: []string{"r"},
119119
Usage: "Rotate logs",
120+
Value: true,
120121
},
121122
&cli.Int64Flag{
122123
Name: "max-size",
@@ -127,6 +128,7 @@ var (
127128
Name: "daily",
128129
Aliases: []string{"d"},
129130
Usage: "Rotate logs daily",
131+
Value: true,
130132
},
131133
&cli.IntFlag{
132134
Name: "max-days",
@@ -137,6 +139,7 @@ var (
137139
Name: "compress",
138140
Aliases: []string{"z"},
139141
Usage: "Compress rotated logs",
142+
Value: true,
140143
},
141144
&cli.IntFlag{
142145
Name: "compression-level",

0 commit comments

Comments
 (0)