Fix JS NPE when viewing specific range of PR commits (#27912) (#27923)

GiteaBot · delvh · web-flow · commit 49f82ac4e37e · 2023-11-06T09:22:44.000Z
Backport #27912 by @delvh This should be the easiest fix. While other solutions might be possible that exterminate the root cause, they will not be as trivial. Co-authored-by: delvh <dev.lh@web.de>
diff --git a/web_src/js/components/DiffCommitSelector.vue b/web_src/js/components/DiffCommitSelector.vue
@@ -94,7 +94,7 @@ export default {
     focusElem(elem, prevElem) {
       if (elem) {
         elem.tabIndex = 0;
-        prevElem.tabIndex = -1;
+        if (prevElem) prevElem.tabIndex = -1;
         elem.focus();
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ export default {`
`94`	`94`	`focusElem(elem, prevElem) {`
`95`	`95`	`if (elem) {`
`96`	`96`	`elem.tabIndex = 0;`
`97`		`- prevElem.tabIndex = -1;`
	`97`	`+ if (prevElem) prevElem.tabIndex = -1;`
`98`	`98`	`elem.focus();`
`99`	`99`	`}`
`100`	`100`	`},`