fix comment and code, fix lint

Author: wxiaoguang

modules/graceful/manager.go

@@ -60,14 +60,15 @@ func InitManager(ctx context.Context) {
 	})
 }
 
-// RunWithCancel helps to run a function with a custom context, the cancel function will be called at shutdown
+// RunWithCancel helps to run a function with a custom context, the Cancel function will be called at shutdown
+// The Cancel function should stop the Run function in predictable time.
 func (g *Manager) RunWithCancel(rc RunCanceler) {
 	g.RunAtShutdown(context.Background(), rc.Cancel)
 	g.runningServerWaitGroup.Add(1)
 	defer g.runningServerWaitGroup.Done()
 	defer func() {
 		if err := recover(); err != nil {
-			log.Critical("PANIC during RunWithCustomContext: %v\nStacktrace: %s", err, log.Stack(2))
+			log.Critical("PANIC during RunWithCancel: %v\nStacktrace: %s", err, log.Stack(2))
 			g.doShutdown()
 		}
 	}()

modules/log/event_writer_base.go

@@ -58,8 +58,6 @@ func (b *EventWriterBaseImpl) GetLevel() Level {
 
 // Run is the default implementation for EventWriter.Run
 func (b *EventWriterBaseImpl) Run(ctx context.Context) {
-	pprof.SetGoroutineLabels(ctx)
-
 	defer b.OutputWriteCloser.Close()
 
 	var exprRegexp *regexp.Regexp
@@ -155,6 +153,7 @@ func eventWriterStartGo(ctx context.Context, w EventWriter, shared bool) {
 	go func() {
 		defer writerCancel()
 		defer close(w.Base().stopped)
+		pprof.SetGoroutineLabels(writerCtx)
 		w.Run(writerCtx)
 	}()
 }

modules/log/init.go

@@ -13,8 +13,10 @@ import (
 	"code.gitea.io/gitea/modules/util/rotatingfilewriter"
 )
 
-var projectPackagePrefix string
-var processTraceDisabled atomic.Int64
+var (
+	projectPackagePrefix string
+	processTraceDisabled atomic.Int64
+)
 
 func init() {
 	_, filename, _, _ := runtime.Caller(0)

modules/notification/ui/ui.go

@@ -54,7 +54,7 @@ func handler(items ...issueNotificationOpts) []issueNotificationOpts {
 }
 
 func (ns *notificationService) Run() {
-	graceful.GetManager().RunWithCancel(ns.issueQueue)
+	go graceful.GetManager().RunWithCancel(ns.issueQueue) // TODO: using "go" here doesn't seem right, just leave it as old code
 }
 
 func (ns *notificationService) NotifyCreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository,

modules/queue/workerqueue.go

@@ -23,9 +23,8 @@ type WorkerPoolQueue[T any] struct {
 	ctxRun       context.Context
 	ctxRunCancel context.CancelFunc
 
-	// ctxShutdown  atomic.Pointer[context.Context]
 	shutdownDone    chan struct{}
-	shutdownTimeout atomic.Int64
+	shutdownTimeout atomic.Int64 // in case some buggy handlers (workers) would hang forever, "shutdown" should finish in predictable time
 
 	origHandler HandlerFuncT[T]
 	safeHandler HandlerFuncT[T]