Skip to content

Commit 846a70e

Browse files
committed
more tests
1 parent 6cf07ce commit 846a70e

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

modules/packages/arch/metadata_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"archive/tar"
88
"bytes"
99
"compress/gzip"
10-
"fmt"
1110
"io"
1211
"testing"
1312

@@ -123,14 +122,13 @@ func TestParsePackageInfo(t *testing.T) {
123122
assert.ErrorIs(t, err, ErrInvalidName)
124123
})
125124

126-
for _, v := range []string{"", "a:1.0.0-1", "0.0.1/1-1", "1.0.0 -1"} {
127-
t.Run(fmt.Sprintf("InvalidVersion[%s]", v), func(t *testing.T) {
128-
data := createPKGINFOContent(packageName, v)
129-
p, err := ParsePackageInfo(bytes.NewReader(data))
130-
assert.Nil(t, p)
131-
assert.ErrorIs(t, err, ErrInvalidVersion)
132-
})
133-
}
125+
t.Run("Regexp", func(t *testing.T) {
126+
assert.Regexp(t, versionPattern, "1.2_3~4+5")
127+
assert.Regexp(t, versionPattern, "1:2_3~4+5")
128+
assert.NotRegexp(t, versionPattern, "a:1.0.0-1")
129+
assert.NotRegexp(t, versionPattern, "0.0.1/1-1")
130+
assert.NotRegexp(t, versionPattern, "1.0.0 -1")
131+
})
134132

135133
t.Run("Valid", func(t *testing.T) {
136134
data := createPKGINFOContent(packageName, packageVersion)

0 commit comments

Comments
 (0)