do the attachment directories copy only for the related tests

Author: lunny

tests/integration/release_test.go

@@ -243,6 +243,8 @@ func TestViewTagsList(t *testing.T) {
 func TestDownloadReleaseAttachment(t *testing.T) {
 	defer tests.PrepareTestEnv(t)()
 
+	tests.PrepareAttachmentsStorage(t)
+
 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
 
 	url := repo.Link() + "/releases/download/v1.1/README.md"

tests/test_utils.go

@@ -179,6 +179,20 @@ func InitTest(requireGitea bool) {
 	routers.InitWebInstalled(graceful.GetManager().HammerContext())
 }
 
+func PrepareAttachmentsStorage(t testing.TB) {
+	// prepare attachments directory and files
+	assert.NoError(t, storage.Clean(storage.Attachments))
+
+	s, err := storage.NewStorage(setting.LocalStorageType, &setting.Storage{
+		Path: filepath.Join(filepath.Dir(setting.AppPath), "tests", "testdata", "data", "attachments"),
+	})
+	assert.NoError(t, err)
+	assert.NoError(t, s.IterateObjects("", func(p string, obj storage.Object) error {
+		_, err = storage.Copy(storage.Attachments, p, s, p)
+		return err
+	}))
+}
+
 func PrepareTestEnv(t testing.TB, skip ...int) func() {
 	t.Helper()
 	ourSkip := 1
@@ -213,18 +227,6 @@ func PrepareTestEnv(t testing.TB, skip ...int) func() {
 		}
 	}
 
-	// prepare attachments directory and files
-	assert.NoError(t, storage.Clean(storage.Attachments))
-
-	s, err := storage.NewStorage(setting.LocalStorageType, &setting.Storage{
-		Path: filepath.Join(filepath.Dir(setting.AppPath), "tests", "testdata", "data", "attachments"),
-	})
-	assert.NoError(t, err)
-	assert.NoError(t, s.IterateObjects("", func(p string, obj storage.Object) error {
-		_, err = storage.Copy(storage.Attachments, p, s, p)
-		return err
-	}))
-
 	// load LFS object fixtures
 	// (LFS storage can be on any of several backends, including remote servers, so we init it with the storage API)
 	lfsFixtures, err := storage.NewStorage(setting.LocalStorageType, &setting.Storage{