Skip to content

Commit c46080b

Browse files
earl-warrenGustedwxiaoguang
authored
Remove "tabindex" from some form buttons (#27892)
Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order. --------- Co-authored-by: Gusted <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
1 parent d1dc9cb commit c46080b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

templates/repo/diff/box.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@
238238
"DropzoneParentContainer" ".ui.form"
239239
)}}
240240
<div class="text right edit buttons">
241-
<button class="ui cancel button" tabindex="3">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
242-
<button class="ui primary save button" tabindex="2">{{ctx.Locale.Tr "repo.issues.save"}}</button>
241+
<button class="ui cancel button">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
242+
<button class="ui primary save button">{{ctx.Locale.Tr "repo.issues.save"}}</button>
243243
</div>
244244
</div>
245245
</template>

templates/repo/issue/view_content.tmpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,20 +92,20 @@
9292
<div class="text right">
9393
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .DisableStatusChange)}}
9494
{{if .Issue.IsClosed}}
95-
<button id="status-button" class="ui primary basic button" tabindex="6" data-status="{{ctx.Locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.reopen_comment_issue"}}" name="status" value="reopen">
95+
<button id="status-button" class="ui primary basic button" data-status="{{ctx.Locale.Tr "repo.issues.reopen_issue"}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.reopen_comment_issue"}}" name="status" value="reopen">
9696
{{ctx.Locale.Tr "repo.issues.reopen_issue"}}
9797
</button>
9898
{{else}}
9999
{{$closeTranslationKey := "repo.issues.close"}}
100100
{{if .Issue.IsPull}}
101101
{{$closeTranslationKey = "repo.pulls.close"}}
102102
{{end}}
103-
<button id="status-button" class="ui red basic button" tabindex="6" data-status="{{ctx.Locale.Tr $closeTranslationKey}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.close_comment_issue"}}" name="status" value="close">
103+
<button id="status-button" class="ui red basic button" data-status="{{ctx.Locale.Tr $closeTranslationKey}}" data-status-and-comment="{{ctx.Locale.Tr "repo.issues.close_comment_issue"}}" name="status" value="close">
104104
{{ctx.Locale.Tr $closeTranslationKey}}
105105
</button>
106106
{{end}}
107107
{{end}}
108-
<button class="ui primary button" tabindex="5">
108+
<button class="ui primary button">
109109
{{ctx.Locale.Tr "repo.issues.create_comment"}}
110110
</button>
111111
</div>
@@ -162,8 +162,8 @@
162162

163163
<div class="field">
164164
<div class="text right edit">
165-
<button class="ui basic cancel button" tabindex="3">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
166-
<button class="ui primary save button" tabindex="2">{{ctx.Locale.Tr "repo.issues.save"}}</button>
165+
<button class="ui basic cancel button">{{ctx.Locale.Tr "repo.issues.cancel"}}</button>
166+
<button class="ui primary save button">{{ctx.Locale.Tr "repo.issues.save"}}</button>
167167
</div>
168168
</div>
169169
</div>

0 commit comments

Comments
 (0)