-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
When there is no branch protected, the reviews of those who have code write permission should be consider as official #10624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I thought it was always official unless there's a whitelist and the user is not in it. Maybe we've missed that case for unprotected branches? |
@guillep2k see https://github.com/go-gitea/gitea/blob/master/models/review.go#L195 , when there is no branch protected, no reviewer will be consider as official. |
As Syndrome said: "if everyone is special, then nobody is special" 😄 I agree, I think those should be "official". |
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
I think this has been resolved by #32415 |
Uh oh!
There was an error while loading. Please reload this page.
As above.
If no branch protected, then no official review. Should we change that?
The text was updated successfully, but these errors were encountered: