Skip to content

Approval count should show on failure status too #27208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
silverwind opened this issue Sep 23, 2023 · 1 comment
Open

Approval count should show on failure status too #27208

silverwind opened this issue Sep 23, 2023 · 1 comment
Labels
type/bug

Comments

@silverwind
Copy link
Member

silverwind commented Sep 23, 2023 •
edited
Loading

Description

Noticed this on https://gitea.com/gitea/act/pulls:

image

Both PRs have 1 approval, but only the first one shows "1 approval" in the list. Presumably because the second one failed the checks.

Gitea Version

1.21

Can you reproduce the bug on the Gitea demo site?

Not tested but I assume it would.
@lng2020
Copy link
Member

lng2020 commented Sep 26, 2023

It is not relevant to action, but it's indeed a bug about official field in review table. See(https://gitea.com/gitea/go-sdk/pulls/631)
ksnip_20230926-121636

@silverwind silverwind mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @lng2020