Skip to content

Public keys are not (any more) public #28898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f403 opened this issue Jan 22, 2024 · 3 comments
Open

Public keys are not (any more) public #28898

f403 opened this issue Jan 22, 2024 · 3 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@f403
Copy link

f403 commented Jan 22, 2024

Description

Starting from some of recent releases user's public keys have different visibility as before.

Previously pages like https://try.gitea.io/f403.keys were visible for anybody ignoring user's visibility settings.
Now it returns 404 for users with "limited" or "private" visibility, if requested by guests. This breaks pipelines relying on Gitea.

I couldn't find in the changelog anything about public keys, is this a bug or a feature?
If this is a desired behavior, I'd like to suggest an option in user settings to make public keys public even for limited/private accounts.

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker / https://try.gitea.io/

Database

MySQL/MariaDB

@f403 f403 added the type/bug label Jan 22, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 22, 2024

I think the behavior is "fixed" by a PR, because your user's visibility is not "public".

IIRC it is a suggested "security/privacy" fix. Will try to find the PR ...

@wxiaoguang
Copy link
Contributor

This one: Dont leak private users via extensions (#28023)

@f403
Copy link
Author

f403 commented Jan 22, 2024

Thank you!
Then it would be reasonable to have optional exception for ssh and/or gpg keys.

Can somebody convert this to a feature request please?

@delvh delvh added type/proposal The new feature has not been accepted yet but needs to be discussed first. and removed type/bug labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants