Why is my empty required variable still passing the check?

[usersina]

• Task version: v3.36.0
• Operating system: Arch Linux x86_64 6.6.28-1-lts
• Experiments enabled: No

Given the following Taskfile.yml:

version: "3"

silent: true

vars:
  IMAGE_NAME: my-web-app
  CONTAINER_REGISTRY: # docker.io

tasks:
  check-missing:
    desc: Test the task variables
    requires:
      vars: [CONTAINER_REGISTRY]
    cmds:
      - echo "CONTAINER_REGISTRY is {{.CONTAINER_REGISTRY}}"

My check-missing is not working as intended.

Actual output

CONTAINER_REGISTRY is

Expected output

task: Task "check-missing" cancelled because it is missing required variables: CONTAINER_REGISTRY

This works as intended if I simply delete CONTAINER_REGISTRY or comment it out, but why isn't it working if it's empty?

[trulede]

The variable is set to nil (try this - echo "CONTAINER_REGISTRY is {{spew .CONTAINER_REGISTRY}}") ... and the code is only checking if the variable exists, not if it is also set.

If you ask me, it's a bug.

[trulede]

I've opened a PR for this : #1677

We tried requires but found it did not work how we expected. So I've also suggested a change to the behavior.