-
-
Notifications
You must be signed in to change notification settings - Fork 686
Watch sends interrupt signal right away in v3.43.x #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can confirm that the watch is broken
When running |
+1 same |
I opened #2271 that intends to fix this. Please give it a try and let me know if it's working for you. |
Works better, but still not quite as it should. It works when first invoking it, but then starts either sending the signal or looping after a while. I've tested it with the following version: ❯ ./bin/task --version
3.43.3+de7ecf1 Below's a bit more complex example, where it doesn't work at all (works with Another interesting thing is, if I run it with ---
# yaml-language-server: $schema=https://taskfile.dev/schema.json
version: '3'
interval: 500ms
env:
PACKAGE:
sh: awk '/module/ {print $NF}' ./src/go.mod
tasks:
default:
silent: true
cmd: task --list
build:
desc: Build the service
label: "{{.ALIAS}}"
dir: ./src
deps:
- generate:templ
- generate:ui
cmds:
- rm -f ./bin/hello
- go build -o ./bin/hello {{.PACKAGE}}/cmd
sources:
- "./go.mod"
- "./go.sum"
- "./**/*.go"
- ./ui/assets/css/main.css
generates:
- ./bin/hello
generate:templ:
desc: Generate templates
label: "{{.ALIAS}}"
dir: ./src
cmds:
- find ./ -type f -name '*_templ.go' -delete
- templ generate --path ./
sources:
- ./ui/**/*.templ
generates:
- ./ui/**/*_templ.go
internal: true
generate:ui:
desc: Generate UI
label: "{{.ALIAS}}"
dir: ./src
deps:
- ui:deps
cmds:
- npx @tailwindcss/cli -i ./ui/assets/css/input.css -o ./ui/assets/css/main.css
sources:
- ./ui/assets/css/input.css
- ./ui/**/*.templ
generates:
- ./ui/assets/css/main.css
internal: true
ui:deps:
desc: Install UI dependencies
cmd: npm install
dir: ./src
sources:
- ./package.json
generates:
- ./node_modules
- ./package-lock.json
internal: true
run:
desc: Run the service
label: "{{.ALIAS}}"
dir: ./src
deps:
- build
cmd: ./bin/hello {{.CLI_ARGS}} |
Description
Upgrading from
v3.42.1
tov3.43.x
(both .1 and .2) breaks the--watch
functionality.Using an older version, for example,
v3.42.1
, works as it should:With
v3.43.x
, the following happens:The behaviour is the same using the Homebrew version as well as from source.
The above output is from the following Go code:
Version
v3.43.x
Operating system
all
Experiments Enabled
No response
Example Taskfile
The text was updated successfully, but these errors were encountered: