Skip to content

Commit 05d6677

Browse files
committed
fix: do not affect benchmarks
1 parent bc80cbb commit 05d6677

File tree

2 files changed

+30
-8
lines changed

2 files changed

+30
-8
lines changed

dynamodb/dynamodb_test.go

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,12 @@ func Benchmark_DynamoDB_Set(b *testing.B) {
179179
require.NoError(b, err)
180180
defer testStore.Close()
181181

182+
errs := make([]error, b.N)
182183
for i := 0; i < b.N; i++ {
183-
err = testStore.Set("john", []byte("doe"), 0)
184+
errs[i] = testStore.Set("john", []byte("doe"), 0)
185+
}
186+
187+
for _, err := range errs {
184188
require.NoError(b, err)
185189
}
186190
}
@@ -196,8 +200,13 @@ func Benchmark_DynamoDB_Get(b *testing.B) {
196200
b.ReportAllocs()
197201
b.ResetTimer()
198202

203+
errs := make([]error, b.N)
199204
for i := 0; i < b.N; i++ {
200205
_, err = testStore.Get("john")
206+
errs[i] = err
207+
}
208+
209+
for _, err := range errs {
201210
require.NoError(b, err)
202211
}
203212
}
@@ -210,11 +219,13 @@ func Benchmark_DynamoDB_SetAndDelete(b *testing.B) {
210219
require.NoError(b, err)
211220
defer testStore.Close()
212221

222+
errs := make([]error, b.N)
213223
for i := 0; i < b.N; i++ {
214-
err = testStore.Set("john", []byte("doe"), 0)
215-
require.NoError(b, err)
224+
_ = testStore.Set("john", []byte("doe"), 0)
225+
errs[i] = testStore.Delete("john")
226+
}
216227

217-
err = testStore.Delete("john")
228+
for _, err := range errs {
218229
require.NoError(b, err)
219230
}
220231
}

nats/nats_test.go

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -368,8 +368,12 @@ func Benchmark_Nats_Set(b *testing.B) {
368368
b.ReportAllocs()
369369
b.ResetTimer()
370370

371+
errs := make([]error, b.N)
371372
for i := 0; i < b.N; i++ {
372-
err = testStore.Set("john", []byte("doe"), 0)
373+
errs[i] = testStore.Set("john", []byte("doe"), 0)
374+
}
375+
376+
for _, err := range errs {
373377
require.NoError(b, err)
374378
}
375379
}
@@ -385,8 +389,13 @@ func Benchmark_Nats_Get(b *testing.B) {
385389
b.ReportAllocs()
386390
b.ResetTimer()
387391

392+
errs := make([]error, b.N)
388393
for i := 0; i < b.N; i++ {
389394
_, err = testStore.Get("john")
395+
errs[i] = err
396+
}
397+
398+
for _, err := range errs {
390399
require.NoError(b, err)
391400
}
392401
}
@@ -399,11 +408,13 @@ func Benchmark_Nats_SetAndDelete(b *testing.B) {
399408
b.ReportAllocs()
400409
b.ResetTimer()
401410

411+
errs := make([]error, b.N)
402412
for i := 0; i < b.N; i++ {
403-
err = testStore.Set("john", []byte("doe"), 0)
404-
require.NoError(b, err)
413+
_ = testStore.Set("john", []byte("doe"), 0)
414+
errs[i] = testStore.Delete("john")
415+
}
405416

406-
err = testStore.Delete("john")
417+
for _, err := range errs {
407418
require.NoError(b, err)
408419
}
409420
}

0 commit comments

Comments
 (0)