Skip to content

Commit f523e9f

Browse files
vangentbep
authored andcommitted
deploy: Don't treat a NotFound response for Delete as a fatal error.
1 parent 63cd05c commit f523e9f

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

deploy/deploy.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import (
4545
_ "gocloud.dev/blob/fileblob" // import
4646
_ "gocloud.dev/blob/gcsblob" // import
4747
_ "gocloud.dev/blob/s3blob" // import
48+
"gocloud.dev/gcerrors"
4849
)
4950

5051
// Deployer supports deploying the site to target cloud providers.
@@ -238,9 +239,13 @@ func (d *Deployer) Deploy(ctx context.Context) error {
238239
go func(del string) {
239240
jww.INFO.Printf("Deleting %s...\n", del)
240241
if err := bucket.Delete(ctx, del); err != nil {
241-
errMu.Lock()
242-
defer errMu.Unlock()
243-
errs = append(errs, err)
242+
if gcerrors.Code(err) == gcerrors.NotFound {
243+
jww.WARN.Printf("Failed to delete %q because it wasn't found: %v", del, err)
244+
} else {
245+
errMu.Lock()
246+
defer errMu.Unlock()
247+
errs = append(errs, err)
248+
}
244249
}
245250
<-sem
246251
}(del)

0 commit comments

Comments
 (0)