Skip to content

Commit 4accfe1

Browse files
committed
net: re-enable TestDualStack{TCP,UDP}Listener on dragonfly
It looks like the latest DragonFly BSD kernels, at least 4.4 and above, have finished working on handling of shared IP control blocks. Let's re-enbale test cases referring to IP control blocks and see what happens. Updates #13146. Change-Id: Icbe2250e788f6a445a648541272c99b598c3013d Reviewed-on: https://go-review.googlesource.com/19406 Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent b48120c commit 4accfe1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/net/listen_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,12 @@ var dualStackTCPListenerTests = []struct {
216216
// TestDualStackTCPListener tests both single and double listen
217217
// to a test listener with various address families, different
218218
// listening address and same port.
219+
//
220+
// On DragonFly BSD, we expect the kernel version of node under test
221+
// to be greater than or equal to 4.4.
219222
func TestDualStackTCPListener(t *testing.T) {
220223
switch runtime.GOOS {
221-
case "dragonfly", "nacl", "plan9": // re-enable on dragonfly once the new IP control block management has landed
224+
case "nacl", "plan9":
222225
t.Skipf("not supported on %s", runtime.GOOS)
223226
}
224227
if !supportsIPv4 || !supportsIPv6 {
@@ -303,9 +306,12 @@ var dualStackUDPListenerTests = []struct {
303306
// TestDualStackUDPListener tests both single and double listen
304307
// to a test listener with various address families, different
305308
// listening address and same port.
309+
//
310+
// On DragonFly BSD, we expect the kernel version of node under test
311+
// to be greater than or equal to 4.4.
306312
func TestDualStackUDPListener(t *testing.T) {
307313
switch runtime.GOOS {
308-
case "dragonfly", "nacl", "plan9": // re-enable on dragonfly once the new IP control block management has landed
314+
case "nacl", "plan9":
309315
t.Skipf("not supported on %s", runtime.GOOS)
310316
}
311317
if !supportsIPv4 || !supportsIPv6 {

0 commit comments

Comments
 (0)